[PKG-Openstack-devel] Bug#858257: python-glanceclient: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:python-glanceclient
Version: 1:2.5.0-3
Severity: important

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
py3versions: no X-Python3-Version in control file, using supported versions
dh build-indep --buildsystem=python_distutils --with python2,python3,sphinxdoc
   dh_testdir -i -O--buildsystem=python_distutils
   dh_update_autotools_config -i -O--buildsystem=python_distutils
   dh_auto_configure -i -O--buildsystem=python_distutils
   dh_auto_build -i -O--buildsystem=python_distutils
pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
	python setup.py build --force
running build
running build_py

[... snipped ...]

FAIL: glanceclient.tests.unit.test_shell.ShellCacheSchemaTest.test_cache_schemas_gets_when_forced
glanceclient.tests.unit.test_shell.ShellCacheSchemaTest.test_cache_schemas_gets_when_forced
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "/<<PKGBUILDDIR>>/glanceclient/tests/unit/test_shell.py", line 786, in test_cache_schemas_gets_when_forced
    open.mock_calls[2])
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 350, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 435, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = call().write('{"properties": {"name": {"description": "Name of image", "type": "string"}}, "name": "image"}')
actual    = call().write('{"properties": {"name": {"type": "string", "description": "Name of image"}}, "name": "image"}')


======================================================================
FAIL: glanceclient.tests.unit.test_shell.ShellCacheSchemaTest.test_cache_schemas_gets_when_not_exists
glanceclient.tests.unit.test_shell.ShellCacheSchemaTest.test_cache_schemas_gets_when_not_exists
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "/<<PKGBUILDDIR>>/glanceclient/tests/unit/test_shell.py", line 809, in test_cache_schemas_gets_when_not_exists
    open.mock_calls[2])
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 350, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 435, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = call().write('{"properties": {"name": {"description": "Name of image", "type": "string"}}, "name": "image"}')
actual    = call().write('{"properties": {"name": {"type": "string", "description": "Name of image"}}, "name": "image"}')


----------------------------------------------------------------------
Ran 549 tests in 36.693s

FAILED (failures=2, skipped=7)
debian/rules:26: recipe for target 'override_dh_auto_test' failed
make[1]: *** [override_dh_auto_test] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:8: recipe for target 'build-indep' failed
make: *** [build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2
--------------------------------------------------------------------------------

This is just how the build ends, not necessarily the relevant part.

I've put several build logs here:

https://people.debian.org/~sanvila/build-logs/python-glanceclient/

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the page for this package.

The bug should be reproducible with sbuild on a single CPU virtual machine,
provided you try enough times (as the failure happens randomly).

Please note that the failure rate observed here is around 10%,
so instead of trying to reproduce it yourself, it could be more
productive to look at the code and the build logs and try to guess
how it may happen.

Thanks.