[PKG-Openstack-devel] python-keystonemiddleware dependency in Swift & patch for O_TMPFILE

Thomas Goirand zigo at debian.org
Tue Mar 13 12:44:11 UTC 2018


On 03/13/2018 12:47 PM, Ondrej Novy wrote:
> I don't trust you and I hate you, because this change is wrong. I told
> you this and you still uploaded wrong fix.

It's not because you told me that I agree. It's not because you told
that it becomes truth. It's ok to not agree. Let's fix things in a way
so that we're both happy with the technical decision. Uploads can always
be reverted, that's fine.

> keystonemiddleware is needed only if you are using Keystone.

Of course I know.

> So after this change i need to have whole Keystone dependency> chain installed.

The where we don't agree: I don't think that hurts. If you do, then we
can revert, if you do have a use case where you think it is bad, I do
respect it.

> sounds like Recommends/Suggest.

Let's upload with Recommends: then. I was anyway considering it, but
though it was best to handle all auth cases.

> Using Keystone as auth for Swift is not so common.

Debating over use case statistics will lead nowhere.

>     https://review.openstack.org/#/c/552093/
> 
> I don't have problem with your fix and thanks for it.

Great!

> tl;dr: I'm preparing correct fix. Which was true from yesterday/beginning.

You don't have to, I can do it if you prefer. Yesterday I could feel you
seemed very busy and I didn't want to bother.

Cheers,

Thomas Goirand (zigo)

P.S: I'd be nice if you came back on IRC.



More information about the Openstack-devel mailing list