Bug#358255: [Pbuilder-maint] Bug#358255: Make pbuilder fail with a meaningful error when .changes file is used instead of .dsc

[Junichi Uekawa]

At Thu, 30 Mar 2006 13:45:34 -0700,
Oleksandr Moskalenko wrote:
> 
> * Junichi Uekawa <dancer at netfort.gr.jp> [2006-03-25 14:31:14 +0900]:
> 
> > Hi
> > 
> > Please retain cc to the bug report.
> > 
> > 
> > > 1. Have pbuilder print out a warning if the file extension is not .dsc -
> > > something along the lines of 
> > > 
> > > "A .dsc file must be the last parameter of a pbuilder command.
> > > Please verify your command. 
> > > 
> > > Trying to proceed with the current command."
> > 
> > 
> > 
> > > 2. After printing the above messages try to parse the actual file. I think all
> > > you need is at least one line after the 
> > > "Files:"
> > > or you could look at all the lines until the first blank line. The difference
> > > between the .changes file and the .dsc file is that those lines in the
> > > .changes file have 5 fields separated by space(s) and the .dsc file has only 3
> > > fields. I think it shouldn't be fragile.
> > 
> > After a bit more thought, this sounds like over-engineering.  Is there
> > any existing tool that can be used for verification ?
> > 
> > How about using some of dpkg tools, they should be able to check.
> Junichi,
> 
> I think it's pretty straightforward and doesn't constitute over-engineering. I
> asked about this on #debian-mentors and the advice was to
> 
> "parse it as an rfc822 message, and see if it has the correct fields take into
> account an optional pgp signature".

Of course, you are welcome to provide a patch.
However, it must not fail when dsc/changes files change format.

They are both rfc822 messages, and they don't identify themselves
about what format they are in.

regards,
	junichi
-- 
dancer@{debian.org,netfort.gr.jp}   Debian Project