[Pbuilder-maint] Bug#415546: pbuilder: Build-dep resolution cannot determine the architecture being built on when building under fakeroot

[Paul TBBle Hampson]

Package: pbuilder
Version: 0.164
Severity: normal
Tags: patch

Basically, dpkg-architecture called during build-deps resolution fails
calling getpwname if the build user is not in /etc/passwd. However, in
/usr/lib/pbuilder-buildpackage, the checkbuilddep call comes before the
createbuilduser call.

This will cause a build-failure for any package which depends on
something architecture-specific. (I hit this rebuilding PHP5 which
build-depends on firebird2-dev [i386 amd64] on an i386 pbuilder-uml
setup) This particularly hits pbuilder-uml as pbuilder-uml defaults to
the fakeroot build process.

I believe this breakage happened with the change to when
dpkg-architecture is run in 0.164, but haven't looked to confirm that.

This change also means that the hooks have access to getpwnam and
related.

I think this is important: for pbuilder-uml, but the bug itself is in
pbuilder, where it obviously isn't affecting most people.

The patch is as follows:
--- pbuilder-buildpackage	2007-03-20 16:01:28.000000000 +1100
+++ pbuilder-buildpackage	2007-03-20 16:36:21.000000000 +1100
@@ -88,13 +88,13 @@
 
 
 recover_aptcache
+createbuilduser
 echo "Installing the build-deps"
 executehooks "D"
 trap saveaptcache_umountproc_cleanbuildplace exit
 checkbuilddep "$PACKAGENAME"
 save_aptcache
 trap umountproc_cleanbuildplace exit
-createbuilduser
 
 echo "Copying source file"
 copydsc "$PACKAGENAME" "$BUILDPLACE/tmp/buildd"

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-686
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)

Versions of packages pbuilder depends on:
ii  coreutils                     5.97-5.3   The GNU core utilities
ii  debianutils                   2.17.5     Miscellaneous utilities specific t
ii  debootstrap                   0.3.3.2    Bootstrap a basic Debian system
ii  gcc                           4:4.1.1-15 The GNU C compiler
ii  wget                          1.10.2-2   retrieves files from the web

Versions of packages pbuilder recommends:
pn  cowdancer                     <none>     (no description available)
ii  devscripts                    2.9.27     Scripts to make the life of a Debi
ii  fakeroot                      1.6.3      Gives a fake root environment
ii  sudo                          1.6.8p12-4 Provide limited super user privile

-- no debconf information

-- 
Paul "TBBle" Hampson, Paul.Hampson at Pobox.com

Shorter .sig for a more eco-friendly paperless office.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20070320/35e4f3da/attachment.pgp