Bug#415544: [Pbuilder-maint] Bug#415544: pbuilder-uml: pbuilder-user-mode-linux blindly overrides DHCP configuration with static IP configuration

[Junichi Uekawa]

Hi,

> The below patch only overwrites the /etc/network/interfaces in
> the chroot if a UML_IP is specified, and refuses to do so when
> a COWFILE has not been specified, or if pbuilder-uml.conf has
> UML_IP=dhcp
> in it.
> 
> (You could change it to be UML_IP= if you change "${UML_IP} != 'dhcp'
> to be -n "${UML_IP}". I don't mind which style myself.)
> 
> This allows command-line overriding of the uml_ip to run multiple
> instances of a static-IP'd UML, and without a cow file, you
> really shouldn't be trying to run multiple instances anyway.
> 
> (The second change allows dhclient3 to work, it needs /proc for some
> reason)

The concept of the patch sounds good.


This part below is executed inside user-mode-linux, and by that time,
PBUILDER_COW is not defined. Are you sure about this logic?

> +if [ -n "${PBUILDER_COW}" -a "${UML_IP}" != 'dhcp']; then
>  cat <<IP > ${UML_CHROOT_MOUNTPOINT}/etc/network/interfaces
>  auto lo
>  iface lo inet loopback




regards,
	junichi
-- 
dancer@{debian.org,netfort.gr.jp}   Debian Project