[Pbuilder-maint] Bug#416918: pbuilder-uml: Daemons started by /etc/init.d/networking start are not given a chance to stop

[Paul TBBle Hampson]

Package: pbuilder-uml
Version: 0.165
Severity: minor
Tags: patch

Although /etc/init.d/networking start is called within the chroot before
pbuilder is run, a corresponding /etc/init.d/networking stop call is not
made.

This means that if a daemon (such as dhclient3) is started, it will not
be stopped, and the volume will fail to unmount.

This problem only shows up due to the patch in #415544, which makes
the /etc/network/interfaces in the chroot in the uml possible to be
something other than a static IPv4 configuration. It also only shows
up when a COW device is not used.

It's minor because the problem (at least when I hit it) only causes
the device to be unclean when remounted at next boot, and dhclient3
to observe that a pid file is already in place, but neither of these
actually prevents the functionality from working.

The below patch fixes this.

--- /usr/bin/pbuilder-user-mode-linux	2007-03-30 21:50:27.000000000 +1000
+++ pbuilder-user-mode-linux	2007-03-31 23:18:31.000000000 +1000
@@ -150,6 +150,17 @@
 fi
 pbuilder "$1" ${UML_EXTRAOPT} \${EXTRAOPT[@]} --buildresult "\${BUILDRESULT}" --buildplace "${UML_CHROOT_MOUNTPOINT}" --internal-build-uml ${UML_DEBUGMODE:+--debug} ${BUILDING_DSC_FILE}  ${UML_EXECUTE_EXTRAOPT} 
 echo \$? > /proc/exitcode
+cat <<SHELL > ${UML_CHROOT_MOUNTPOINT}/tmp/chrootshell
+#! /bin/bash
+${UML_DEBUGMODE}
+# the shell executed inside chroot inside UML
+    echo Stopping network inside the chroot
+    mount -t proc /proc /proc
+    /etc/init.d/networking stop
+    umount /proc
+SHELL
+chmod a+x ${UML_CHROOT_MOUNTPOINT}/tmp/chrootshell
+chroot ${UML_CHROOT_MOUNTPOINT} /tmp/chrootshell
 
 if [ -n "\${kernel_modules}" ] ; then
 	umount /lib/modules
-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-686
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)

Versions of packages pbuilder-uml depends on:
ii  pbuilder                    0.164        personal package builder for Debia
ii  rootstrap                   0.3.24-2     A tool for building complete Linux
ii  user-mode-linux             2.6.18-1um-2 User-mode Linux (kernel)

pbuilder-uml recommends no packages.

-- no debconf information

-- 
Paul "TBBle" Hampson, Paul.Hampson at Pobox.com

Shorter .sig for a more eco-friendly paperless office.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20070331/67128ec2/attachment.pgp