Bug#459432: pbuilder: invalid "Upgrading for distribution xyz" message on update

[Andreas Beckmann]

Package: pbuilder
Version: 0.177
Severity: minor
Tags: patch

Hi,

when no --override-config option is given, options like --distribution,
.... (or their .pbuilderrc counterparts DISTRIBUTION, ...) are not taken
into account for setting up the chroot, they also shouldn't be used for
outputting diagnostics.

E.g. I have pbuilder environments for sid, lenny and etch (and some
wrapper scripts pbuilder-DIST/pdebuild-DIST selecting the correct
tarball) and my .pbuilderrc says DISTRIBUTION=lenny.
On update I get
    $ pbuilder-sid update
    Upgrading for distribution lenny
    Building the build Environment
    ...
which is incorrect (and perhaps misleading: "WTF is it switching from
sid to lenny?").

I'd suggest to drop the message (or remove the "distribution xyz" part)
unless --override-config is there, the following one line patch for
pbuilder-updatebuildenv should do this:

25c25
< if [ -n "$DISTRIBUTION" ]; then
---
> if [ -n "$DISTRIBUTION" ] && [ "$OVERRIDE_APTLINES" = "yes" ]; then


Andreas


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable'), (300, 'unstable'), (130, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.23-1-686 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages pbuilder depends on:
ii  cdebootstrap                  0.4.3      Bootstrap a Debian system
ii  coreutils                     5.97-5.3   The GNU core utilities
ii  debianutils                   2.28.2     Miscellaneous utilities specific t
ii  debootstrap                   1.0.7      Bootstrap a basic Debian system
ii  gcc                           4:4.2.2-1  The GNU C compiler
ii  wget                          1.10.2-3   retrieves files from the web

Versions of packages pbuilder recommends:
ii  cowdancer                     0.44       Copy-on-write directory tree utili
ii  devscripts                    2.10.11    Scripts to make the life of a Debi
ii  fakeroot                      1.8.10     Gives a fake root environment
ii  sudo                          1.6.9p9-1  Provide limited super user privile

-- no debconf information