Bug#333294: [Pbuilder-maint] Bug#333294: Info received (A patch for the default mirror)

[Eddy Petrișor]

tags 333294 patch
# now that there is a working patch, fixing the bug is only a matter of
# merging the patch
severity 333294 minor
thanks

Eddy Petrișor wrote:
> On 29/06/2007, Junichi Uekawa <dancer at netfort.gr.jp> wrote:
>> Hi,
> 
> Hello again,
> 
> This is a mail to say that I have returned to the issue and will
> publish my results on alioth:
> 
> http://git.debian.org/?p=users/eddyp-guest/pbuilder.git;a=summary

I have pushed these changes into my repo, and, in the form they are now, 
they should be ok for inclusion in the package.


You can pull my changes from the master branch of this repo:
git://git.debian.org/git/users/eddyp-guest/pbuilder.git

For tacking purposes I have attached to the mail a monolithic patch 
realtive to current git master.



I have tested this in the following situations:
- no pbuilderrc, no sources.list, no sources.list.d/*.sources.list
- no pbuilderrc
- all present

It seems it works fine.

I haven't given any thought to add any test in the test suite.

What would be needed now would be a review of the po-debconf templates 
from the smith project, then a call for translations on the 
debian-i18n at l.d.o list.

> Progres details follow:

I ran debconf-updatepo and made a complete Romanian translation.

>>  2. generate /etc/pbuilderrc from /usr/share/pbuilder/pbuilderrc, using
>>    the debconf-provided defaults.
> 
> Needs to be done (postinst feeds on /etc/pbuilderrc even if it doesn't exist).

Done

Now uses information from /etc/apt/sources.list and 
/etc/apt/sources.list.d/*.sources.list. If that information proves to be 
insufficient to get the right information, it will fall back to user 
input. If the questions are not shown (e.g. priority critical), the 
fallback is to use
http://ftp.debian.org/debian

>>  3. make sure pbuilder doesn't change in such a way to require change in default configuration file
> 
> That is your problem :-)
> 
>>  pbuilder should work fine with an empty or nonexisting
>>  /etc/pbuilderrc, since it can pull the default from
> 
> Does that work now?

I have left a TODO comment in the postinst about this issue, since I 
didn't knew if it was ok to leave just the MIRRORSITE in the configuration.

>>  /usr/share/pbuilder/pbuilderrc, and newer configuration variables will
>>  be taken from there, so upgrade cases shouldn't cause too much
>>  problem.
> 
> Does pbuilder work properly if pbuilderrc is minimalistic (i.e.
> contains only MIRRORSITE=...)?
> 
> Then generating a minimal /etc/pbuilderrc with the default sources it
> all that it takes to fix this bug (in the light of my existing work),
> right?

Still waiting.

-- 
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 333294.patch
Type: text/x-diff
Size: 14053 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20080302/276398ce/attachment.patch