Bug#542915: pbuilder removes data from bind-mounted directories

[Matthew Palmer]

On Mon, Dec 27, 2010 at 10:41:36PM -0600, Steve M. Robbins wrote:
> On Tue, Dec 28, 2010 at 09:38:30AM +1100, Matthew Palmer wrote:
> > On Mon, Dec 27, 2010 at 05:04:02PM +0100, Julien Cristau wrote:
> > > do you plan on NMUing pbuilder for this bug?
> > 
> > No, I don't consider it appropriate to NMU for an RC bug that I raised the
> > severity on, withouth the acknowledgement of the maintainer that the
> > severity is justified.  Someone else NMUing is a vote that the severity is
> > justified.
> 
> The original submitter agreed with you on the severity.  That's good 
> enough for me.  
> 
> I can do the upload if you like.

That'd be good.

> However, I'm confused by your
> message of 2010-12-17, where you said "Patch 5 in a series:".  I'm
> confused because I can see only one patch prior to this, and the later
> patch seems to be a patch on the original patch.  Can you
> confirm whether the following is the intended change or whether
> there are 4 other patches I'm missing.  

Sorry about the confusion.  My local branch for this bug, 542915 in
http://github.com/mpalmer/pbuilder, has three other patches in it (to
auto-unmount everything, rename mountproc to mountall, and improve an error
message), and so the other patch I attached to this bug report is #5 in that
series.

To clarify, the two patches that needed to fix this bug are:

0001-Ensure-that-nothing-is-still-mounted-before-deleting.patch
0005-Robustify-the-is-anything-mounted-check.patch

The other three patches in the series are refactorings/improvements, and
should not (IMHO) be made as part of an NMU.

- Matt