[PATCH 7/9] Set $PROFILE and $PBUILDER_ROOT to null

Osamu Aoki osamu at debian.org
Sat Jan 23 12:37:05 UTC 2010


On Sat, Jan 23, 2010 at 12:07:30AM +0100, Loïc Minier wrote:
> On Sun, Jan 17, 2010, Loïc Minier wrote:
> > +PBUILDER_ROOT=""
> > +PROFILE=""
> 
>  This doesn't seem to make it possible to override these from the
>  testsuite anymore.

Do you think command which does sudo to change is behavior based on
environment variable and source random code to be OK?

I have no problem /usr/lib/pbuilder/foo to change behavior.  But I did
not /usr/bin/pdebuild or /usr/sbin/pbuilder to change their behavior.

This security concern was rationale behind this.  But since other
variables also needs to be initialized, this may not be meaningful.

Osamu



More information about the Pbuilder-maint mailing list