Bug#567484: pbuilder: -e$DEBEMAIL instead of -e$DEBFULLNAME <$DEBEMAIL> used for dpkg-buildpackage

[Loïc Minier]

tags 567484 - patch
stop

On Fri, Jan 29, 2010, Jean-Christophe Dubacq wrote:
> In /usr/lib/pbuilder/pbuilder-buildpackage, the call to dpkg-buildpackage reads:
> COMMANDLINE="dpkg-buildpackage -us -uc ${DEBEMAIL:+\"-e$DEBEMAIL\"} $DEBBUILDOPTS"
> which generates .changes with a Changed-By: line with only the email address instead
> of the full stanza.

 This is because you didn't set DEBEMAIL with your name; you can set:
    DEBEMAIL="Loïc Minier <lool at dooz.org>"

 We should deal with this better, but this is going to be subtle;
 checkout the code of dch for reference handling of these vars:
if (exists $env{'DEBEMAIL'} and $env{'DEBEMAIL'} =~ /^(.*)\s+<(.*)>$/) {
    $env{'DEBFULLNAME'} = $1 unless exists $env{'DEBFULLNAME'};
    $env{'DEBEMAIL'} = $2;
}
if (! exists $env{'DEBEMAIL'} or ! exists $env{'DEBFULLNAME'}) {
    if (exists $env{'EMAIL'} and $env{'EMAIL'} =~ /^(.*)\s+<(.*)>$/) {
        $env{'DEBFULLNAME'} = $1 unless exists $env{'DEBFULLNAME'};
        $env{'EMAIL'} = $2;
    }
}

 the logic continues for some dozens of lines.

 In an ideal world, consider making this code a separate utility, e.g.
 get-debian-maintainer which would output:
    EMAIL="foobar at baz"
    NAME="Foo Bar"

   Thanks!
-- 
Loïc Minier