Bug#587254: [pbuilder] please use a more meaningful error message in unloadhooks()

Cristian Greco cristian at regolo.cc
Sat Jun 26 17:19:37 UTC 2010


Package: pbuilder
Version: 0.198
Severity: wishlist

Hi,

please use a less cryptic message than the actual one in unloadhooks()
(in /usr/lib/pbuilder/pbuilder-runhooks) when failing to remove the
hook directory inside chroot:

function unloadhooks () {
    if [ -z "$HOOKDIR" ]; then
	return ;
    fi
    if [ -d "$BUILDPLACE/$hooks" ]; then
	rm -rf "$BUILDPLACE/$hooks"
    else
	log "E: Logic failure."
    fi
}

In my case, $HOOKDIR is set in ~/.pbuilderrc but the directory does not
actually exist, so i get the following log messages:

...
W: hookdir /var/cache/pbuilder/hooks/unstable/ does not exist, skipping
...
E: Logic failure.
...

Thanks,
--
Cristian Greco
GPG key ID: 0xCF4D32E4

--- System information. ---
Architecture: amd64
Kernel:       Linux 2.6.34-1-amd64

Debian Release: squeeze/sid
  500 unstable        ftp.at.debian.org 
    1 experimental    ftp.debian.org 

--- Package information. ---
Depends             (Version) | Installed
=============================-+-=============
debootstrap                   | 1.0.23
 OR cdebootstrap              | 
wget                          | 1.12-2
debianutils       (>= 1.13.1) | 3.2.3
coreutils        (>= 4.5.8-1) | 8.5-1
debconf             (>= 0.5)  | 1.5.32
 OR debconf-2.0               | 


Recommends      (Version) | Installed
=========================-+-===========
fakeroot                  | 1.14.4-1
sudo                      | 1.7.2p7-1
devscripts                | 2.10.64


Suggests          (Version) | Installed
===========================-+-===========
pbuilder-uml                | 
gdebi-core                  | 
cowdancer                   | 0.61
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20100626/05f765fd/attachment.pgp>


More information about the Pbuilder-maint mailing list