Bug#567484: pbuilder: -e$DEBEMAIL instead of -e$DEBFULLNAME

[Miguel Colon]

>>>That makes sense: with no args, dpkg-buildpackage does the right thing
>>>if DEBEMAIL is set and DEBFULLNAME is set.
>>>So let the work be done by dpkg-buildpackage.
>
> I’ve found that most Debian tools work best if DEBFULLNAME is not set
> and DEBEMAIL is "Foo Bar <fbar at debian.org>".

Only tool that gives me issues using the DEBFULLNAME / DEBEMAIL
correctly is pbuilder. But that is rather off-topic

The issue is rather simple. If I send a package to build with pbuilder
even with hooks to modify the source and to add a new changelog entry
it should always reach the dpkg-buildpackage line with a valid
FULLNAME/EMAIL in the last changelog entry. Why are we running the
"-e" option to change the behavior of dpkg-genchanges?

-emaintaineraddress
              Use maintaineraddress as the name and email address of
the maintainer for this upload, rather than using the information from
the source tree's changelog.

The package was changed by the person in the last entry of the
changelog not the value of whatever you decide to put in DEBEMAIL
therefore the "Changed-by" tag should be as the default
dpkg-buildpackage/dpkg-genchanges behavior does.

The only reason I patch this is so that the lintian hook that I run do
not give me a failure due to a silly E: caused by pbuilder using the
-e option without an apparent need.

-Miguel