Bug#772290: pbuilder: bashism in /bin/sh script

[Thorsten Glaser]

Raphael Geissert dixit:

>checkbashisms' output:
>> possible bashism in ./usr/lib/pbuilder/pbuilder-unshare-wrapper line 4
>> (should be >word 2>&1):
>>	  echo >&@ E: $2 returned error code $1

This is a misdetection (a bug in checkbashisms), but also a genuine typo
(should have been “>&2”). I’ll open a bug there.

*re-checks current sources and bugreport*

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=753944#96

Hrm.

Apparently, mksh continues with an error, GNU bash continues
without an error, and dash aborts the script there. (Neither
show the actual error message.)

Now looking at the context.

Just running /usr/lib/pbuilder/pbuilder-unshare-wrapper as
non-root is enough to trigger the line, due to lack of per‐
missions. This is in the error handling code. In all three
shell cases, the fallback is sane.

As this is only prio:important, and doesn’t impede the
software negatively, and DTRT in all cases except not
showing the correct error message (nor the next line,
in dash), this doesn’t need to be fixed for jessie.
(If, on the other hand, someone decides to tackle the
/etc/resolv.conf-in-the-chroot issue from that same
bugreport, and the RT allows that into jessie, this
can probably (with the RT’s approval) piggyback on it.)

As I wrote in #753944#96, this should be fixed by the
maintainer when merging the NMU, post-unfreeze or in
experimental.

Sorry for this mess. I take responsibility.

bye,
//mirabilos
-- 
(gnutls can also be used, but if you are compiling lynx for your own use,
there is no reason to consider using that package)
	-- Thomas E. Dickey on the Lynx mailing list, about OpenSSL