[RFC][PATCH] qemubuilder: Add qemu machine type overwrite.
Mattia Rizzolo
mattia at mapreri.org
Fri Nov 13 17:32:04 UTC 2015
On Fri, Nov 13, 2015 at 05:52:32PM +0100, Benedikt Spranger wrote:
> BTW: What is the prefered way to discuss some ideas around qemubuilder?
well, in general I see most of the people prefers handling everything as
bug reports. It depends on the maintainer and happens both the current
cowdancer (source of qemubuilder maintainer) and me (=> actually the
only two active people in the pbuilder team) prefers BTS :)
Actually: I'm not that interested in cowdancer, I don't think I ever
committed something to it at all, that's why I didn't look at your
patch, I don't know the codebase and it'd take a lot of time.
The other maintainer (irl) filed a RFA (https://bugs.debian.org/802151),
he doesn't really have the time to deal with everything.
> IMHO the source of qemubuilder needs some refactoring:
>
> 1) Arch configuration: Make all(nearly all) hardcoded values
> configurable. I am contemplate in a per architecture configuration
> snippets.
>
> 2) Error handling: Fix return value. qemubuilder returned 0 in almost
> every situation. This is awkward in an automated build environment.
agree, simply.
> 3) Coding style: It would be nice to have one :)
In my opinion if this is the case then you should just step up as a
co-maintainer of cowdancer, at least for qemubuilder.
And if you're going to do such refactoring/work then you should really
also look at the bug list.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20151113/49960852/attachment.sig>
More information about the Pbuilder-maint
mailing list