Bug#847944: pbuilder: get_source_control_field doesn't accept preceding comment

[Mattia Rizzolo]

control: tag -1 confirmed

On Mon, Dec 12, 2016 at 09:05:00AM -0600, Daniel Drake wrote:
> The change made in bug #694404 introduce a regression.
> pbuilder-satisfydepends-classic can no longer detect the Build-Depends if
> it is preceded by a comment, e.g.
> 
> Source: my package
> #foo
> Build-Depends: debhelper (>= 9)

To reproduce this using the test suite, use this tiny change:

%<-------------
--- a/t/test_pbuilder-satisfydepends-funcs
+++ b/t/test_pbuilder-satisfydepends-funcs
@@ -53,6 +53,7 @@ test_get_build_deps_source_para_only() {
     local BINARY_ARCH="$1"
     cat <<EOF >"$DEBIAN_CONTROL"
 Source: foo
+# foo
 Build-Depends: bar
 EOF
     get_build_deps
------------>%
%<-------------
mattia at warren ~/devel/pbuilder/pbuilder (git)-[master] % PBUILDER_CHECKOUT=. t/test_pbuilder-satisfydepends-funcs
[FAIL] test_get_build_deps_source_para_only expected [bar] but got []
t/test_pbuilder-satisfydepends-funcs: Ran 52 tests and 51 succeeded, 1 failed
=================
Testsuite FAILED!
  t/test_pbuilder-satisfydepends-funcs
=================
1 mattia at warren ~/devel/pbuilder/pbuilder (git)-[master] %                                                                                                                         :(
------------>%


Pity this requires sed(1) wizardry, which is not to be found my backyard.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20161231/17fc133e/attachment.sig>