Bug#810967: pbuilder: adds MIRRORSITE to /etc/pbuilderrc on each upgrade, overwriting local admin config

[Mattia Rizzolo]

On Thu, Jan 14, 2016 at 06:48:08PM +0000, Thorsten Glaser wrote:
> Mattia Rizzolo dixit:
> 
> >Then, reading debian/pbuilder.config only if MIRRORSITE is not set, do
> >you confirm that you don't have it set?
> 
> I say I *do* have it set. pbuilderrc attached.

yes, you do, indeed:

> eval MIRRORSITE=\$MIRROR_$DISTRIBUTION; export MIRRORSITE

But I think this is not catched by the current script, which does

    CURRENTMIRROR=$(grep -E "^[ 	]*MIRRORSITE=" "$CONFFILE" | sed 's#MIRRORSITE=##g')
    if [ "$CURRENTMIRROR" ] ; then
        # do stuff...
    else
        # no MIRRORSITE line found in the pbuilderrc file
        echo "MIRRORSITE=$PLACEHOLDER" >> "$CONFFILE"
    fi


e.g. `grep -E "^[ 	]*MIRRORSITE=" "$CONFFILE"` is not enough.

I'm more tempted to just drop the whole thing. e.g. if the file is
missing do try to detect the mirror and add it, but if the file is
already there, then just walk away (unless the used asked explicetely
to overwrite the conf through debconf).


BTW, did you just recently changed it?  I can't believe this went
unobserved for years :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20160114/8728e667/attachment.sig>