Bug#840146: pbuilder: remove_packages checks for existence in host, not in chroot

[Thorsten Glaser]

Package: pbuilder
Version: 0.226.1
Severity: serious
Justification: breaks basic use

The remove_packages function in pbuilder-modules contains:

        if (dpkg -s "$pkg" 2>&1)>/dev/null ; then

This obviously must be:

        if ($CHROOTEXEC dpkg -s "$pkg" 2>&1)>/dev/null ; then

Because of this, I can’t “upgrade” (reads: switch between apt- and
aptitude-based resolvers) my sarge chroot any more.

-- System Information:
Debian Release: stretch/sid
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'buildd-unstable'), (500, 'unstable')
Architecture: x32 (x86_64)
Foreign Architectures: i386, amd64

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/lksh
Init: sysvinit (via /sbin/init)

Versions of packages pbuilder depends on:
ii  debconf [debconf-2.0]  1.5.59
ii  debootstrap            1.0.84
ii  dpkg-dev               1.18.10
ii  wget                   1.18-4

Versions of packages pbuilder recommends:
ii  devscripts  2.16.8
ii  eatmydata   105-3
ii  fakeroot    1.21-2
ii  iproute2    4.6.0-4
ii  net-tools   1.60+git20150829.73cef8a-2
ii  sudo        1.8.17p1-2

Versions of packages pbuilder suggests:
ii  cowdancer   0.81
pn  gdebi-core  <none>

-- debconf information excluded

-- debsums errors found:
debsums: changed file /usr/lib/pbuilder/pbuilder-modules (from pbuilder package)