Bug#850478: git-pbuilder deliberately deletes source.changes

[Mattia Rizzolo]

On Fri, Jan 06, 2017 at 06:18:14PM -0800, Russ Allbery wrote:
> James Clarke <jrtc27 at debian.org> writes:
> > Currently, straight after git-pbuilder invokes pdebuild, it deletes
> > ../*_source.changes, provided there is at least one such file, and the
> > build was not done with -S. This causes two problems:
> 
> I did that originally for two reasons.  One, historically, the
> *_source.changes file was completely worthless, since it was generated to
> move the source package into the pbuilder chroot, where the source package
> is then regenerated (and source-only builds weren't a thing).

They weren't a thing in Debian, but at the very least Ubuntu never ever
supported binary uploads (trying to image somebody using gbp for ubuntu
packages, even if I don't know anybody who would do that).

> >  1. It ignores version numbers and package names, causing potential data
> >     loss, which I feel is justification enough for the Severity: important.
> 
> Yeah, it does that because I didn't know how to do better (and this
> started life as my personal script for my workflow, and at the time all
> *_source.changes files were garbage).

umh, $pkg_$version_source.changes? :)

> >     Now, I'm of the view that dpkg-source -b should be used instead,
> >     which is what sbuild uses to create the dsc. This also has the
> >     advantage of not generating .buildinfo files (no annoying
> >     debian/files lingering after the build, either). Then the only
> >     _source.changes generated by pbuilder would be if the user requested
> >     it, and therefore having it deleted by git-pbuilder would be wrong.
> 
> Yeah, this seems reasonable to me.  Definitely happy to change
> git-pbuilder once pdebuild is fixed to not produce the spurious and
> useless *_changes.file.

Indeed, is this a suggestion for pdebuild?
Also consider that while moving from dpkg-buildpackage to dpkg-source
imho we should continue to call everything dpkg-buildpackage used to
call, namely:
    dpkg-source --before-build .
    fakeroot debian/rules clean
    dpkg-source -b .
    dpkg-source --after-build .
Do you agree?

Although, I wouldn't be happy: I'm now used to call `pdebuild`, have it
build my package, and then upload either the ../$pkg_$ver_source.changes
if source only are allowed to the target suite, or the _amd64.changes
otherwise; I don't have any "clash problem" since I have BUILDRESULT set
to another "global" directory.
https://xkcd.com/1172/

> >     I should think changes like this are too late for Stretch, but
> >     perhaps for Buster (or experimental?) we could coordinate our
> >     efforts to get this to work?

yap.

> > I appreciate this is a lot of irrelevant details, but I hope by
> > explaining where we are and where I'd like to get to makes the issues
> > clear. A lot of this will end up going into a bug report against
> > pbuilder blocked by this tomorrow.

Yes please :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20170107/a5521ed8/attachment.sig>