Bug#852434: cowbuilder: does not work any more

[James Clarke]

Control: severity -1 wishlist
Control: tags -1 wontfix
Control: retitle -1 cowbuilder: No longer accepts command later in arguments list

> On 24 Jan 2017, at 12:07, Thorsten Glaser <tg at mirbsd.de> wrote:
> 
> Package: cowbuilder
> Version: 0.84
> Severity: grave
> Justification: renders package unusable
> 
> tglase at tglase:/tmp $ c dpo --hookdir /home/tglase/.hook/ --debbuildopts "-m'$DEBEMAIL'" --binary-arch --build glibc_2.24-9.dsc
> + sudo env 'DIST=dpo' 'LANG=C' 'LC_CTYPE=C' 'LC_NUMERIC=C' 'LC_TIME=C' 'LC_COLLATE=C' 'LC_MONETARY=C' 'LC_MESSAGES=C' 'LC_PAPER=C' 'LC_NAME=C' 'LC_ADDRESS=C' 'LC_TELEPHONE=C' 'LC_MEASUREMENT=C' 'LC_IDENTIFICATION=C' 'LC_ALL=C' 'LD_LIBRARY_PATH=/usr/lib/libeatmydata' 'LD_PRELOAD=libeatmydata.so' cowbuilder --hookdir /home/tglase/.hook/ --debbuildopts '-m'\''Thorsten Glaser <tg at mirbsd.de>'\' --binary-arch --build glibc_2.24-9.dsc
> E: Unknown operation: --hookdir

You will note from the cowbuilder manpage* that the command should be given as
the first argument, just like pbuilder. Past versions of cowbuilder would
accept the command anywhere in the argument list due to an implementation
detail (it used getopt_long). For 0.84, I added the ability to say "build" or
"b" instead of "--build", like pbuilder accepts. As a result of implementing
this, I removed the "--build" and others from the getopt_long list, and instead
parsed the first argument manually, since getopt_long doesn't let you tell it
about arguments that don't start with "-". While in theory I could scan the
entire list, I don't want to do this. Please fix your script to pass "--build"
(or "build"/"b") as the *first* argument.

Regards,
James

* This includes old versions; it was made clear in version 0.22:

> SYNOPSIS
>        cowbuilder [commands] [options]