Bug#851640: --debbuildopts not propagated anymore to cowbuilder

[James Clarke]

Control: clone -1 -2
Control: retitle -2 pdebuild: --debbuildopts not passed through to dpkg-source
Control: tags -2 confirmed

On 24 Jan 2017, at 14:07, Vincent Bernat <bernat at debian.org> wrote:
> ❦ 19 janvier 2017 08:35 +0100, Vincent Bernat <bernat at debian.org> :
> 
>>>> Actually, breaking it completely wasn't my intention, I'll reinstate
>>>> support for it, sorry for the disruption.
>>> 
>>> The pbuilder from git works fine for me. Thanks!
>> 
>> Well, using "-nc" from gbp buildpackage doesn't work. Is it related or
>> should I investigate more?
> 
> 0.228.1 fixes "-nc", but other options don't work. For example, in some
> cases, I am using "-i" (directly from gbp buildpackage). It seems the
> option is not provided anymore to dpkg-source.
> 
> Downgrading to 0.227 also fixes that.

Yes, you're right, none of the options for dpkg-source are passed through
by pdebuild. Looking at dpkg-buildpackage's source (or --help) gives the
following options which are passed through to other commands:

> Options passed to dpkg-architecture:
>   -a, --host-arch <arch>      set the host Debian architecture.
>   -t, --host-type <type>      set the host GNU system type.
>       --target-arch <arch>    set the target Debian architecture.
>       --target-type <type>    set the target GNU system type.

Irrelevant for pdebuild, since it has its own architecture options, and
doesn't call dpkg-architecture as part of building the source package.

> Options passed to dpkg-genchanges:
>   -si                         source includes orig, if new upstream (default).
>   -sa                         source includes orig, always.
>   -sd                         source is diff and .dsc only.
>   -v<version>                 changes since version <version>.
>   -m, --release-by=<maint>    maintainer for this release is <maint>.
>   -e, --build-by=<maint>      maintainer for this build is <maint>.
>   -C<descfile>                changes are described in <descfile>.
>       --changes-option=<opt>  pass option <opt> to dpkg-genchanges.

Implemented in 0.228.1

> Options passed to dpkg-source:
>   -sn                         force Debian native source format.
>   -s[sAkurKUR]                see dpkg-source for explanation.
>   -z, --compression-level=<level>
>                               compression level to use for source.
>   -Z, --compression=<compressor>
>                               compression to use for source (gz|xz|bzip2|lzma).
>   -i, --diff-ignore[=<regex>] ignore diffs of files matching <regex>.
>   -I, --tar-ignore[=<pattern>]
>                               filter out files when building tarballs.
>       --source-option=<opt>   pass option <opt> to dpkg-source.

These need to be implemented, similar to dpkg-genchanges.
Note to self (and Mattia): these are passed to --before/--after-build,
not just --build.

Regards,
James