Bug#876399: pbuilder: B20autopkgtest hook script uses removed adt-run commands

[Guido Günther]

Hi Mattia,

On Wed, Oct 04, 2017 at 09:44:18PM +0200, Mattia Rizzolo wrote:
> On Wed, Oct 04, 2017 at 08:59:34PM +0200, Guido Günther wrote:
> > Attached patch supports both adt-rn and autopkgtest so we can continue
> > to build in wheezy and jessie.
> 
> ooohhh, I remembered there were some simple bugs lying around while I
> was doing the upload, but I didn't actually looked to the bug list and
> instead only fixed the FTBFS in the upload I did today...
> 
> 
> Thank you very much for the patch, much appreciated!
> Just, I noticed that you introduced an AUTOPKGTEST_OPTIONS without any
> kind of migration from ADT_OPTIONS.  Could you please consider that as
> well in your patch?  Also take care that ADT_OPTIONS is also mentioned
> before the hunks you modified.

Thanks for having a look. It falls back to ADT_OPTION for
AUTOPKGTEST_OPTIONS but uses ADT_OPTIONS for the adt-run in case someone
wants different sets of options for the two.
 -- Guido

> 
> > I doubled the while invocations instead of special casing even more
> > options so it stays easier to extend.
> 
> That's fine in something so short :)
> 
> -- 
> regards,
>                         Mattia Rizzolo
> 
> GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
> more about me:  https://mapreri.org                             : :'  :
> Launchpad user: https://launchpad.net/~mapreri                  `. `'`
> Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-B20aupkgtest-Prefer-autopkgtest-over-adt-run.patch
Type: text/x-diff
Size: 2884 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pbuilder-maint/attachments/20171005/40f3a9fc/attachment.patch>