[Pcsclite-cvs-commit] r5845 - /trunk/PCSC/src/winscard_clnt.c

[rousseau at users.alioth.debian.org]

Author: rousseau
Date: Wed Jul  6 12:15:38 2011
New Revision: 5845

URL: http://svn.debian.org/wsvn/pcsclite/?sc=1&rev=5845
Log:
SCardConnect(): use safer strlcpy() instead of strncpy()

coverity: Event buffer_size_warning: Calling strncpy with a maximum size
argument of 100 bytes on destination array "scConnectStruct.szReader" of
size 100 bytes might leave the destination string unterminated.

Modified:
    trunk/PCSC/src/winscard_clnt.c

Modified: trunk/PCSC/src/winscard_clnt.c
URL: http://svn.debian.org/wsvn/pcsclite/trunk/PCSC/src/winscard_clnt.c?rev=5845&op=diff
==============================================================================
--- trunk/PCSC/src/winscard_clnt.c (original)
+++ trunk/PCSC/src/winscard_clnt.c Wed Jul  6 12:15:38 2011
@@ -895,7 +895,7 @@
 		 * -> so the mMutex has been unlocked */
 		return SCARD_E_INVALID_HANDLE;
 
-	strncpy(scConnectStruct.szReader, szReader, sizeof scConnectStruct.szReader);
+	strlcpy(scConnectStruct.szReader, szReader, sizeof scConnectStruct.szReader);
 
 	scConnectStruct.hContext = hContext;
 	scConnectStruct.dwShareMode = dwShareMode;