[Pcsclite-cvs-commit] r6535 - /trunk/PCSC/src/winscard_svc.c

rousseau at users.alioth.debian.org rousseau at users.alioth.debian.org
Tue Feb 19 10:34:03 UTC 2013


Author: rousseau
Date: Tue Feb 19 10:34:02 2013
New Revision: 6535

URL: http://svn.debian.org/wsvn/pcsclite/?sc=1&rev=6535
Log:
Fix a bug reported by scan-build(1)

Value stored to 'retval' is never read

An else statement was missing

Modified:
    trunk/PCSC/src/winscard_svc.c

Modified: trunk/PCSC/src/winscard_svc.c
URL: http://svn.debian.org/wsvn/pcsclite/trunk/PCSC/src/winscard_svc.c?rev=6535&op=diff
==============================================================================
--- trunk/PCSC/src/winscard_svc.c (original)
+++ trunk/PCSC/src/winscard_svc.c Tue Feb 19 10:34:02 2013
@@ -856,7 +856,8 @@
 					"list_append failed with return value: %d", lrv);
 				retval = SCARD_E_NO_MEMORY;
 			}
-			retval = SCARD_S_SUCCESS;
+			else
+				retval = SCARD_S_SUCCESS;
 		}
 
 		(void)pthread_mutex_unlock(&threadContext->cardsList_lock);




More information about the Pcsclite-cvs-commit mailing list