[Pcsclite-cvs-commit] r6559 - /trunk/contrib/libPCSCv2part10/PCSCv2part10.c

rousseau at users.alioth.debian.org rousseau at users.alioth.debian.org
Wed Mar 6 14:18:25 UTC 2013


Author: rousseau
Date: Wed Mar  6 14:18:24 2013
New Revision: 6559

URL: http://svn.debian.org/wsvn/pcsclite/?sc=1&rev=6559
Log:
cppcheck: Variable 'rv' is assigned a value that is never used.

Check the value returned by SCardControl() and return -1 in case of
error.

Modified:
    trunk/contrib/libPCSCv2part10/PCSCv2part10.c

Modified: trunk/contrib/libPCSCv2part10/PCSCv2part10.c
URL: http://svn.debian.org/wsvn/pcsclite/trunk/contrib/libPCSCv2part10/PCSCv2part10.c?rev=6559&op=diff
==============================================================================
--- trunk/contrib/libPCSCv2part10/PCSCv2part10.c (original)
+++ trunk/contrib/libPCSCv2part10/PCSCv2part10.c Wed Mar  6 14:18:24 2013
@@ -118,6 +118,8 @@
 
 	rv= SCardControl(hCard, properties_in_tlv_ioctl, NULL, 0,
 		buffer, sizeof buffer, &length);
+	if (rv != SCARD_S_SUCCESS)
+		return -1;
 
 	return PCSCv2Part10_find_TLV_property_by_tag_from_buffer(buffer,
 		length, property, value);




More information about the Pcsclite-cvs-commit mailing list