[Pcsclite-muscle] Error handling when reading driver configs

[Maksim Ivanov]

Hello Ludovic,

Thanks for fast fixing.


> I knew you sould report more problems :-)

:) I actually discovered this problem some time ago, just forgot to
report it together with the others.


> Note that hotplug_linux should not be used since 2003, and hotplug_libusb since 2008.
> See http://ludovicrousseau.blogspot.fr/2011/02/ for some history.

Thanks for the information.

We planned to use libusb hotplug mechanism in the PC/SC-Lite port
under Chrome Native Client (at least, in the first version of the
port). So the concern is now - aren't there any plans to remove this
branch of hotplug code?


Thanks,
Maksim


On Fri, Mar 18, 2016 at 1:50 PM, Ludovic Rousseau
<ludovic.rousseau at gmail.com> wrote:
>
> 2016-03-18 13:16 GMT+01:00 Maksim Ivanov <emaxx at google.com>:
>>
>> Hello,
>
>
> Hello,
>
> I knew you sould report more problems :-)
>
>> The error handling seems to be incorrect in some cases when the driver configs cannot be read.
>>
>> In file hotplug_libusb.c, function HPReadBundleValues() returns value -1 on some errors, but then its return value is treated like boolean.
>
>
> Fixed in 9d0438ae384c33276d671cdf0830fe5d51901192
>
>>
>> In file hotplug_linux.c, the function's return value is not checked.
>
>
> Fixed in 152746d73149dff6218667b83b053233f2d3d476
>
> Note that hotplug_linux should not be used since 2003, and hotplug_libusb since 2008.
> See http://ludovicrousseau.blogspot.fr/2011/02/ for some history.
>
> Bye
>
> --
>  Dr. Ludovic Rousseau
>
> _______________________________________________
> Pcsclite-muscle mailing list
> Pcsclite-muscle at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pcsclite-muscle