<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2016-04-08 20:50 GMT+02:00 Andrey R <span dir="ltr"><<a href="mailto:andrey.roussev@gmail.com" target="_blank">andrey.roussev@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi. <br></div></blockquote><div><br></div><div>Hello,<br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Valgrind detected usage of uninitialized memory in SCardConnect:<br><br>==19635== Memcheck, a memory error detector<br>==19635== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.<br>==19635== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info<br>==19635== Command: /usr/rtests/bin/Pkcs11UnitTest.X64 pkcs11_common<br>==19635== <br>Running pkcs11_common<br>pkcs11_common::testGetInfo==19635== Syscall param socketcall.sendto(msg) points to uninitialised byte(s)<br>==19635== at 0x605A1F7: send (send.c:32)<br>==19635== by 0xBC47CE6: ??? (in /lib/x86_64-linux-gnu/libpcsclite.so.1.0.0)<br>==19635== by 0xBC47E22: ??? (in /lib/x86_64-linux-gnu/libpcsclite.so.1.0.0)<br>==19635== by 0xBC43BBE: SCardConnect (in /lib/x86_64-linux-gnu/libpcsclite.so.1.0.0)<br>...<br><br>connect_struct.szReader involved. Patch for resolving the problem:<br>root@test-x64-ub13:/tmp# diff -u pcsc-lite-1.8.16/src/winscard_clnt.c{,.patched}<br>--- pcsc-lite-1.8.16/src/winscard_clnt.c 2016-03-12 23:03:09.000000000 +0400<br>+++ pcsc-lite-1.8.16/src/winscard_clnt.c.patched 2016-04-07 16:20:28.193294111 +0400<br>@@ -764,7 +764,7 @@<br> LPDWORD pdwActiveProtocol)<br> {<br> LONG rv;<br>- struct connect_struct scConnectStruct;<br>+ struct connect_struct scConnectStruct = { 0 };<br> SCONTEXTMAP * currentContextMap;<br><br> PROFILE_START<br></div><br></blockquote><div><br></div><div>Fixed in <a href="https://anonscm.debian.org/cgit/pcsclite/PCSC.git/commit/?id=2269f10c2d2c5be1308d59469722024650a19b6d">https://anonscm.debian.org/cgit/pcsclite/PCSC.git/commit/?id=2269f10c2d2c5be1308d59469722024650a19b6d</a><br></div><div><br>I modified your patch since it generated a compiler warning:<br>winscard_clnt.c:767:46: warning: missing field 'szReader' initializer<br>      [-Wmissing-field-initializers]<br>        struct connect_struct scConnectStruct = { 0 };<br>                                                    ^<br><br>Thanks.<br></div></div><br>-- <br><div class="gmail_signature"> Dr. Ludovic Rousseau</div>
</div></div>