pf-tools commit: r589 [ccaillet-guest] - in /trunk: debian/changelog lib/PFTools/Conf.pm

parmelan-guest at users.alioth.debian.org parmelan-guest at users.alioth.debian.org
Tue Mar 18 16:01:43 UTC 2008


Author: ccaillet-guest
Date: Tue Mar 18 16:01:43 2008
New Revision: 589

URL: http://svn.debian.org/wsvn/pf-tools/?sc=1&rev=589
Log:
* Fix warning on possible uninitialized value on Conf.pm

Modified:
    trunk/debian/changelog
    trunk/lib/PFTools/Conf.pm

Modified: trunk/debian/changelog
URL: http://svn.debian.org/wsvn/pf-tools/trunk/debian/changelog?rev=589&op=diff
==============================================================================
--- trunk/debian/changelog (original)
+++ trunk/debian/changelog Tue Mar 18 16:01:43 2008
@@ -40,6 +40,7 @@
     section
   * Creating a hash on Conf.pm for storing vars defined on configuration
     files. Typically used for UML or VMWARE
+  * Fix warning on possible uninitialized value on Conf.pm
 
   [ Thomas Parmelan ]
   * lib-net: if no comment is specified in a zone, network or server
@@ -52,7 +53,7 @@
   * Merge the remaining changes from 0.32.47-1 and 0.32.48-1.
   * Bugfix for hosts without shortname definition.
 
- -- Christophe Caillet <quadchris at free.fr>  Tue, 18 Mar 2008 16:50:17 +0100
+ -- Christophe Caillet <quadchris at free.fr>  Tue, 18 Mar 2008 16:58:11 +0100
 
 pf-tools (0.32.48-1) unstable; urgency=low
 

Modified: trunk/lib/PFTools/Conf.pm
URL: http://svn.debian.org/wsvn/pf-tools/trunk/lib/PFTools/Conf.pm?rev=589&op=diff
==============================================================================
--- trunk/lib/PFTools/Conf.pm (original)
+++ trunk/lib/PFTools/Conf.pm Tue Mar 18 16:01:43 2008
@@ -396,7 +396,7 @@
 		    next;
 		}
 		elsif ( $1 eq "if" ) {
-		    if ( eval $PFTOOLS::Net::PFTOOLS_VARS->{$2} ) {
+		    if ( defined $PFTOOLS::Net::PFTOOLS_VARS->{$2} && eval $PFTOOLS::Net::PFTOOLS_VARS->{$2} ) {
 			unshift @cond, ( $#cond > 0 && !$cond[1] ) ? 0 : 1;
 		    }
 		    else {
@@ -405,7 +405,7 @@
 		    next;
 		}
 		elsif ( $1 eq "ifnot" ) {
-		    if ( !eval $PFTOOLS::Net::PFTOOLS_VARS->{$2} ) {
+		    if ( defined $PFTOOLS::Net::PFTOOLS_VARS->{$2} && !eval $PFTOOLS::Net::PFTOOLS_VARS->{$2} ) {
 			unshift @cond, 0;
 		    }
 		    else {




More information about the pf-tools-commits mailing list