pf-tools/pf-tools: Perlcritic: severity 5 for permission check a...

[parmelan-guest at users.alioth.debian.org]

details:   http://hg.debian.org/hg/pf-tools/pf-tools/rev/971750f50194
changeset: 1062:971750f50194
user:      "Christophe Caillet <quadchris at free.fr>"
date:      Tue Nov 23 12:46:21 2010 +0100
description:
Perlcritic: severity 5 for permission check and severity 2 for named parameter

diffstat:

0 files changed

diffs (21 lines):

diff -r 76354153ecef -r 971750f50194 lib/PFTools/Conf.pm
--- a/lib/PFTools/Conf.pm	Tue Nov 23 11:53:01 2010 +0100
+++ b/lib/PFTools/Conf.pm	Tue Nov 23 12:46:21 2010 +0100
@@ -231,7 +231,7 @@
     my $st = stat $config_file;
 
     # FIXME also check that $uid == 0 && $gid == 0 ?
-    unless ( S_IMODE( $st->mode ) == 0600 and S_ISREG( $st->mode ) ) {
+    unless ( S_IMODE( $st->mode ) == oct("0600") and S_ISREG( $st->mode ) ) {
         croak
             qq{ERROR: weak rights for $config_file (check owner/group/mode)};
     }
@@ -902,7 +902,7 @@
     my ($start_file,    $section_name, $section_ref,
         $global_config, $pf_config,    $hash_subst
         )
-        = @$args{
+        = @{$args}{
         qw( start_file section_name section_ref global_config pf_config hash_subst )
         };