Bug#367337: [Pkg-aide-maintainers] Bug#367337: /var/run/aide.lock breaks non-root use of aide

[Marc Haber]

package aide
tags #367337 - patch
# the patch is not acceptable in this form due to reasons outlined in
# the message body.
thanks

On Mon, May 15, 2006 at 01:23:03AM -0600, Bob Proulx wrote:
> Use of /var/run/aide.lock breaks non-root use of aide.

How about using $HOME/.aide.lock if the wrapper is not invoked as root?

> I suggest also using a lockfile only if no --config is given by the
> user.

Bad idea, IMO. aide can run for a considerable period of time, and two
aide processes operating on the same database guarantee database
breakage.

> Also, printing a message when a user is using --config is not
> expected.  I would like to see the message removed.

I am not going to do this, since running aide without protection of a
lock poses a significant risk to the database.

> Also when using
> $@ you almost always want "$@".

Agreed.

> And passing raw arguments to echo can
> open up possibility of problems there.

I don't see any arguments passed to echo in the aide wrapper. Where do
you see that?

> I am not quite happy with the grep test for a --config option because
> it ignores the -c possibility.  But without doing a full getopts
> parsing it is difficult to get this completely correct.

Agreed. I'd appreciate a patch anyway.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835