[Pkg-anonymity-tools] Bug#793791: Bug#793791: torbrowser-launcher: Fail to start "TypeError: _getEndpoint() takes exactly 4 arguments (2 given)"

[Micah Lee]

On 07/27/2015 08:11 AM, Guillaume Seren wrote:
> Dear maintener,
> while trying to launch torbrowser-launcher it fail,
> and return me this error:
> Tor Browser Launcher
> By Micah Lee, licensed under MIT
> version 0.2.0
> https://github.com/micahflee/torbrowser-launcher
> Updating over Tor
> Checking for update
> Downloading https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions
> Traceback (most recent call last):
>   File "/usr/bin/torbrowser-launcher", line 30, in <module>
>     torbrowser_launcher.main()
>   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/__init__.py", line 69, in main
>     app = Launcher(common, url_list)
>   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line 130, in __init__
>     self.build_ui()
>   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line 284, in build_ui
>     self.start(None)
>   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line 293, in start
>     self.run_task()
>   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line 310, in run_task
>     self.download('update check', self.common.paths['update_check_url'], self.common.paths['update_check_file'])
>   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line 469, in download
>     None)
>   File "/usr/lib/python2.7/dist-packages/twisted/web/client.py", line 1926, in request
>     deferred = self._agent.request(method, uri, headers, bodyProducer)
>   File "/usr/lib/python2.7/dist-packages/twisted/web/client.py", line 1559, in request
>     endpoint = self._getEndpoint(parsedURI)
> TypeError: _getEndpoint() takes exactly 4 arguments (2 given)
> 
> Guillaume.

I can reproduce. By default torbrowser-launcher tries to update over
Tor. A workaround is running "torbrowser-launcher --settings" and
disabling updating over Tor, and then it works fine.

I'm not sure exactly the cause, but it appears to be a bug in
python-twisted-web. Scrapy has run into the same issue [1] and they
resolved it with this commit [2], although it's not clear how to apply
that same fix to torbrowser-launcher.

I just opened an upstream bug [3].

[1] https://github.com/scrapy/scrapy/issues/1034
[2]
https://github.com/scrapy/scrapy/commit/d67ca77e61020802c593c8b60a977e26bebfd7c6
[3] https://github.com/micahflee/torbrowser-launcher/issues/192