[Pkg-anonymity-tools] Bug#797337: torbrowser-launcher: gives misleading error on SOCKS connection failure

[Michael Gold]

Package: torbrowser-launcher
Version: 0.2.0-2

$ torbrowser-launcher
Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.2.0
https://github.com/micahflee/torbrowser-launcher
Updating over Tor
Checking for update
Downloading https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions
Download error: Connection was refused by other side: 111: Connection refused. <class 'twisted.internet.error.ConnectionRefusedError'>

### "Tor Browser" popup dialog appears:
Error starting download:
Connection was refused by other side: 111: Connection refused.
Are you connected to the internet?


An strace reveals it was trying to connect to 127.0.0.1:9050, not to the
internet; code inspection reveals this to be a hard-coded SOCKS address.
The preceding "Downloading https://www.torproject.org…" message makes it
look like it was www.torproject.org that rejected the connection.

Nothing in the torbrowser-launcher man page, any included documentation,
or the console output notes a SOCKS connection is required or gives the
expected address.  "Updating over Tor" is a hint but is not obvious.

The launcher should at least print the address it failed to connect to.
Ideally, it should be able to differentiate between a failed connection
to the SOCKS proxy and an error returned by that proxy, and replace the
"Are you connected to the internet?" message in the former case.

-- Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-anonymity-tools/attachments/20150829/a80937a7/attachment.sig>