[Pkg-anonymity-tools] Bug#797337: Bug#797337: torbrowser-launcher: gives misleading error on SOCKS connection failure

[Michael Gold]

Control: tag -1 + patch

On Sun, Aug 30, 2015 at 13:18:44 +0200, intrigeri wrote:
> Michael Gold wrote (29 Aug 2015 16:35:00 GMT) :
> > An strace reveals it was trying to connect to 127.0.0.1:9050, not to the
> > internet; code inspection reveals this to be a hard-coded SOCKS address.
> > The preceding "Downloading https://www.torproject.org…" message makes it
> > look like it was www.torproject.org that rejected the connection.
> 
> I agree this is a UX problem, thanks for reporting it to Debian.
> Do you want to report it upstream[0]? (I don't remember if the
> upstream author tracks the Debian BTS.)

Here's a patch.  I don't have an account there so I'm CCing Micah.

I didn't handle the case where the remote end rejects the connection.
I'm not sure what exactly it should say, but "Are you connected to the
internet?" isn't relevant in that case.

-- Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: torbrowser-launcher--tor-connect-failure.diff
Type: text/x-diff
Size: 1456 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-anonymity-tools/attachments/20151031/3393f2e5/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-anonymity-tools/attachments/20151031/3393f2e5/attachment.sig>