Bug#415334: [Pkg-awstats-devel] Bug#415334: Patch for the README.Debian file

Jonas Smedegaard dr at jones.dk
Thu Mar 22 22:27:10 CET 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Charles Fry wrote:

> Unless I hear objections from the other awstats maintainers, I'll apply
> your patch.

Excellent text, Eric!

I have one comment, though: That cron line you suggest at the end - did
you actually test that it works? It seems odd to me - a [ -x ] test
should only check if a file has the executable bit set, not actually
execute it. And if it works for you, then also make sure that it works
with non-bash sh variants!

Perhaps advertise the example script for multiple domains.

Perhaps mention why it isn't the default: The package cannot safely
handle upgrades to locally added config files - if config options change
then the main file is updated (with warnings if edited locally) but
extra config files are silently ignored and possibly broken.



But all the above suggestions are just nice additions - if you disagree
or if you don't understand my points, then just consider dropping your
concrete example for a cron entry...


 - Jonas

- --
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

 - Enden er nær: http://www.shibumi.org/eoti.htm
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGAvStn7DbMsAkQLgRAvGuAJ91Oas5f/y5cRVtmgriluI7oryCfwCeKByq
QN45ex+WcNV0QI57fBVyIxk=
=bcSW
-----END PGP SIGNATURE-----




More information about the Pkg-awstats-devel mailing list