[Pkg-awstats-devel] Bug#495432: Bug#495432: Patch is not affective

[Andreas Henriksson]

Hello Florian!

Thanks for looking at this problem!

On ons, 2008-12-03 at 12:16 +0100, Florian Weimer wrote:
> Please use the following patch instead.  (The "onload=" part does not
> harm, but it's easy to circumvent and therefore unnecessary.)

I couldn't see it do any harm, so I had no reason to deviate from
upstreams changes.

> 
> I tried to notify upstream, but the Sourceforge account bounces.  If
> you have got a better contact, please forward this piece of
> information.
> 

I'm the latest sucker to join the awstats maintainance and haven't yet
established any contact with upstream. It's on my todo, but motivation
is a bit lacking unfortunately. Sorry.

> diff --git a/wwwroot/cgi-bin/awstats.pl b/wwwroot/cgi-bin/awstats.pl
> index 8194462..f96ac63 100755
> --- a/wwwroot/cgi-bin/awstats.pl
> +++ b/wwwroot/cgi-bin/awstats.pl
> @@ -4395,6 +4395,7 @@ sub DecodeEncodedString {
>  	my $stringtodecode=shift;
>  	$stringtodecode =~ tr/\+/ /s;
>  	$stringtodecode =~ s/%([A-F0-9][A-F0-9])/pack("C", hex($1))/ieg;
> +	$stringtodecode =~ s/["']//g;
>  	return $stringtodecode;
>  }
>  

To sum it up and make sure I've understood this correctly. The problem
with the previous patch is that it only handles " (%22) while yours
takes care of both " and ', right?

I'll try to fix this up for Unstable (and later get a freeze exception
for Testing). Thanks for taking care of Stable.

-- 
Regards,
Andreas Henriksson