Eric,<br><br>Can you send a new patch when you have all this straightened out, and we'll consider applying it to the next release.<br><br>cheers,<br>Charles<br><br><div><span class="gmail_quote">On 3/22/07, <b class="gmail_sendername">
Eric Wadsworth</b> <<a href="mailto:eric@wadhome.org">eric@wadhome.org</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Jonas,<br><br>Good catch! Those cron lines are running in my system now, but are they<br>working? I just checked, and they aren't! I'll fix them on my system.<br>I'm fairly new to Linux, so I'm glad that you guys checked my
<br>documentation patch for accuracy. I hadn't considered non-bash sh<br>variants either. I think you are right, that last bit about cron should<br>just be dropped from my addition to the readme file. A comment to<br>
explain why this isn't the default, as you suggest, is certainly a good<br>idea too, +1 from me.<br><br>Thanks for all your work!<br><br>--- Eric Wadsworth<br><br>Jonas Smedegaard wrote:<br>> Charles Fry wrote:<br>
><br>> > Unless I hear objections from the other awstats maintainers, I'll apply<br>> > your patch.<br>><br>> Excellent text, Eric!<br>><br>> I have one comment, though: That cron line you suggest at the end - did
<br>> you actually test that it works? It seems odd to me - a [ -x ] test<br>> should only check if a file has the executable bit set, not actually<br>> execute it. And if it works for you, then also make sure that it works
<br>> with non-bash sh variants!<br>><br>> Perhaps advertise the example script for multiple domains.<br>><br>> Perhaps mention why it isn't the default: The package cannot safely<br>> handle upgrades to locally added config files - if config options change
<br>> then the main file is updated (with warnings if edited locally) but<br>> extra config files are silently ignored and possibly broken.<br>><br>><br>><br>> But all the above suggestions are just nice additions - if you disagree
<br>> or if you don't understand my points, then just consider dropping your<br>> concrete example for a cron entry...<br>><br>><br>> - Jonas<br>><br><br></blockquote></div><br>