[Pkg-bazaar-commits] ./bzr-gtk/unstable r291: Put children widget on a new line.

[Jelmer Vernooij]

------------------------------------------------------------
revno: 291
committer: Jelmer Vernooij <jelmer at samba.org>
branch nick: trunk
timestamp: Tue 2007-10-02 06:59:13 +0200
message:
  Put children widget on a new line.
modified:
  NEWS
  logview.py
-------------- next part --------------
=== modified file 'NEWS'
--- a/NEWS	2007-09-26 19:51:30 +0000
+++ b/NEWS	2007-10-02 04:59:13 +0000
@@ -17,6 +17,11 @@
         * Add a column to display the revision number. (#64167)
         * Add buttons to navigate to child revisions.
     (Gary van der Merwe)
+
+ BUG FIXES
+
+  * Show children on new row in table to avoid very broad windows in viz. 
+    (Jelmer)
     
  INTERNALS
 

=== modified file 'logview.py'
--- a/logview.py	2007-08-31 11:24:56 +0000
+++ b/logview.py	2007-10-02 04:59:13 +0000
@@ -116,7 +116,6 @@
         self.tags_list.show_all()
         self.tags_label.show_all()
         
-
     def _add_parents_or_children(self, revids, widgets, table):
         while len(widgets) > 0:
             widget = widgets.pop()
@@ -161,7 +160,9 @@
         vbox = gtk.VBox(False, 6)
         vbox.set_border_width(6)
         vbox.pack_start(self._create_headers(), expand=False, fill=True)
-        vbox.pack_start(self._create_parents_and_children(), expand=False, fill=True)
+        vbox.pack_start(self._create_parents(), expand=False, fill=True)
+        if self.show_children:
+            vbox.pack_start(self._create_children(), expand=False, fill=True)
         vbox.pack_start(self._create_message_view())
         self.add_with_viewport(vbox)
         vbox.show()
@@ -272,20 +273,23 @@
         return self.table
 
     
-    def _create_parents_and_children(self):
-        hbox = gtk.HBox(True, 6)
+    def _create_parents(self):
+        hbox = gtk.HBox(True, 3)
         
         self.parents_table = self._create_parents_or_children_table(
             "<b>Parents:</b>")
         self.parents_widgets = []
         hbox.pack_start(self.parents_table)
-        
-        if self.show_children:
-            self.children_table = self._create_parents_or_children_table(
-                "<b>Children:</b>")
-            self.children_widgets = []
-            hbox.pack_start(self.children_table)
-        
+
+        hbox.show()
+        return hbox
+
+    def _create_children(self):
+        hbox = gtk.HBox(True, 3)
+        self.children_table = self._create_parents_or_children_table(
+            "<b>Children:</b>")
+        self.children_widgets = []
+        hbox.pack_start(self.children_table)
         hbox.show()
         return hbox