[Pkg-bazaar-commits] ./bzr/unstable r377: - todo notes on inventory

[Martin Pool]

------------------------------------------------------------
revno: 377
committer: Martin Pool <mbp at sourcefrog.net>
timestamp: Thu 2005-05-05 18:06:38 +1000
message:
  - todo notes on inventory
modified:
  TODO
  bzrlib/inventory.py
-------------- next part --------------
=== modified file 'TODO'
--- a/TODO	2005-05-05 07:00:17 +0000
+++ b/TODO	2005-05-05 08:06:38 +0000
@@ -210,6 +210,22 @@
   we scan for new children) or files encountered in a directory that's
   being scanned.
 
+* Better handling of possible collisions on case-losing filesystems;
+  make sure a single file does not get added twice under different
+  names.
+
+* Clean up XML inventory:
+
+  - Use nesting rather than parent_id pointers.
+
+  - Hold the ElementTree in memory in the Inventory object and work
+    directly on that, rather than converting into Python objects every
+    time it is read in.  Probably still expose it through some kind of
+    object interface though, but perhaps that should just be a proxy
+    for the elements.
+
+  - Less special cases for the root directory. 
+
 
 Large things
 ------------

=== modified file 'bzrlib/inventory.py'
--- a/bzrlib/inventory.py	2005-05-05 07:57:02 +0000
+++ b/bzrlib/inventory.py	2005-05-05 08:06:38 +0000
@@ -15,9 +15,6 @@
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
 
-# TODO: Maybe store inventory_id in the file?  Not really needed.
-
-
 # This should really be an id randomly assigned when the tree is
 # created, but it's not for now.
 ROOT_ID = "TREE_ROOT"
@@ -289,22 +286,6 @@
     </inventory>
 
     """
-
-    ## TODO: Make sure only canonical filenames are stored.
-
-    ## TODO: Do something sensible about the possible collisions on
-    ## case-losing filesystems.  Perhaps we should just always forbid
-    ## such collisions.
-
-    ## TODO: No special cases for root, rather just give it a file id
-    ## like everything else.
-
-    ## TODO: Probably change XML serialization to use nesting rather
-    ## than parent_id pointers.
-
-    ## TODO: Perhaps hold the ElementTree in memory and work directly
-    ## on that rather than converting into Python objects every time?
-
     def __init__(self):
         """Create or read an inventory.