[Pkg-bitcoin-devel] Bug#765355: NMU debdiff for libbitcoin_2.0-2.1

[Aníbal Monsalve Salazar]

Control: tags -1 + pending

Hello Jonas,

At Imagination Technologies (http://imgtec.com/) Jurica Stanojkovic has
found a solution to Debian bug #765355.

https://bugs.debian.org/765355

My NMU debdiff for libbitcoin_2.0-2.1 is below, at the end of this
message.

With the changes in the NMU debdiff, libbitcoin builds successfully on
mips, mipsel and amd64.

Regards,

Aníbal
--
Aníbal Monsalve Salazar <Anibal.MonsalveSalazar at imgtec.com>

debdiff libbitcoin_2.0-2.dsc libbitcoin_2.0-2.1.dsc
diff -Nru libbitcoin-2.0/debian/changelog libbitcoin-2.0/debian/changelog
--- libbitcoin-2.0/debian/changelog	2014-08-15 12:48:38.000000000 +0100
+++ libbitcoin-2.0/debian/changelog	2014-10-15 08:49:01.000000000 +0100
@@ -1,3 +1,13 @@
+libbitcoin (2.0-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTBFS on big endian architectures.
+    Add big-endian.patch.
+    Patch by Jurica Stanojkovic <Jurica.Stanojkovic at imgtec.com>.
+    Closes: #765355.
+
+ -- Anibal Monsalve Salazar <anibal at debian.org>  Wed, 15 Oct 2014 08:48:57 +0100
+
 libbitcoin (2.0-2) unstable; urgency=medium
 
   * Add patch 1001 to fix include Boost endian include.
diff -Nru libbitcoin-2.0/debian/patches/big-endian.patch libbitcoin-2.0/debian/patches/big-endian.patch
--- libbitcoin-2.0/debian/patches/big-endian.patch	1970-01-01 01:00:00.000000000 +0100
+++ libbitcoin-2.0/debian/patches/big-endian.patch	2014-10-15 08:48:54.000000000 +0100
@@ -0,0 +1,72 @@
+Date: Mon, 13 Oct 2014 13:16:08 +0100
+From: Jurica Stanojkovic <Jurica.Stanojkovic at imgtec.com>
+Subject: package libbitcoin_2.0-2 FTBFS on big endian
+
+http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=765355
+
+Package libbitcoin_2.0-2 FTBFS on big endian architectures.
+https://buildd.debian.org/status/package.php?p=libbitcoin&suite=sid
+
+with the following error:
+
+In file included from ./../include/bitcoin/satoshi_serialize.hpp:24:0,
+                 from satoshi_serialize.cpp:20:
+./../include/bitcoin/format.hpp:49:27: error: #elif with no expression
+     #elif BOOST_BIG_ENDIAN
+                           ^
+./../include/bitcoin/format.hpp:52:10: error: #error "Endian isn't defined!"
+         #error "Endian isn't defined!"
+          ^
+./../include/bitcoin/format.hpp:70:27: error: #elif with no expression
+     #elif BOOST_BIG_ENDIAN
+                           ^
+./../include/bitcoin/format.hpp:73:10: error: #error "Endian isn't defined!"
+         #error "Endian isn't defined!"
+          ^
+In file included from ./../include/bitcoin/satoshi_serialize.hpp:29:0,
+                 from satoshi_serialize.cpp:20:
+./../include/bitcoin/utility/serializer.hpp:348:27: error: #elif with no expression
+     #elif BOOST_BIG_ENDIAN
+                           ^
+./../include/bitcoin/utility/serializer.hpp:351:10: error: #error "Endian isn't defined!"
+         #error "Endian isn't defined!"
+          ^
+make[2]: *** [satoshi_serialize.lo] Error 1
+
+This issue is resolved with the patch below.
+
+Index: libbitcoin-2.0/include/bitcoin/format.hpp
+===================================================================
+--- libbitcoin-2.0.orig/include/bitcoin/format.hpp
++++ libbitcoin-2.0/include/bitcoin/format.hpp
+@@ -46,7 +46,7 @@ T cast_chunk(data_chunk chunk, bool reve
+ {
+     #ifdef BOOST_LITTLE_ENDIAN
+         // do nothing
+-    #elif BOOST_BIG_ENDIAN
++    #elif defined BOOST_BIG_ENDIAN
+         reverse = !reverse;
+     #else
+         #error "Endian isn't defined!"
+@@ -67,7 +67,7 @@ data_chunk uncast_type(T value, bool rev
+     // TODO Future versions of boost will have boost::native_to_little(value);
+     #ifdef BOOST_LITTLE_ENDIAN
+         // do nothing
+-    #elif BOOST_BIG_ENDIAN
++    #elif defined BOOST_BIG_ENDIAN
+         reverse = !reverse;
+     #else
+         #error "Endian isn't defined!"
+Index: libbitcoin-2.0/include/bitcoin/utility/serializer.hpp
+===================================================================
+--- libbitcoin-2.0.orig/include/bitcoin/utility/serializer.hpp
++++ libbitcoin-2.0/include/bitcoin/utility/serializer.hpp
+@@ -345,7 +345,7 @@ private:
+         check_distance(begin, end, byte_array.size());
+     #ifdef BOOST_LITTLE_ENDIAN
+         // do nothing
+-    #elif BOOST_BIG_ENDIAN
++    #elif defined BOOST_BIG_ENDIAN
+         reverse = !reverse;
+     #else
+         #error "Endian isn't defined!"
diff -Nru libbitcoin-2.0/debian/patches/series libbitcoin-2.0/debian/patches/series
--- libbitcoin-2.0/debian/patches/series	2014-08-15 12:37:30.000000000 +0100
+++ libbitcoin-2.0/debian/patches/series	2014-10-14 07:41:48.000000000 +0100
@@ -1 +1,2 @@
 1001_fix_include_Boost_endian.patch
+big-endian.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-bitcoin-devel/attachments/20141015/7957d6fa/attachment.sig>