[pkg-boost-devel] Bug#506939: Bug#506939: boost: setting CFLAGS in debian/rules clobbers environment

[Steve M. Robbins]

Hi Steve,

Bjam is built twice: first using "build.sh" then the newly-built bjam
is used to build the "real" bjam that is used for subsequently
building Boost.


On Tue, Nov 25, 2008 at 11:18:19PM -0800, Steve Langasek wrote:

> I see in the latest version of boost that you're setting
> CFLAGS=-fno-strict-aliasing directly in debian/rules.  This is somewhat
> suboptimal; first, because there's already a patch in the package
> (debian/patches/bjam-no-strict-aliasing) to do exactly this,

The patch bjam-no-strict-aliasing only applies to the second build
(using the bootstrap bjam).  We need to supply
CFLAGS=-fno-strict-aliasing on the first bjam build because otherwise
the first bjam segfaults on some architectures, e.g. alpha [1].


> and second,
> because this clobbers any CFLAGS value that might have been set in the
> package build environment with the intent that it be picked up by packages
> (e.g., build hardening flags).

True; but for the first bjam build, clobbering these flags should be OK.

In short: I think the Debian package is correct as-is and I don't believe
changes are needed.  Do you agree?

Regards,
-Steve

[1] http://buildd.debian.org/fetch.cgi?&pkg=boost&ver=1.34.1-13&arch=alpha&stamp=1225347918&file=log

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-boost-devel/attachments/20081126/d33aa205/attachment.pgp