[Pkg-bugzilla-commits] r111 - trunk/bugzilla-2.18.3/debian

[Alexis Sukrieh]

Author: sukria-guest
Date: 2005-09-12 20:31:50 +0000 (Mon, 12 Sep 2005)
New Revision: 111

Modified:
   trunk/bugzilla-2.18.3/debian/bugzilla.postinst
   trunk/bugzilla-2.18.3/debian/changelog
Log:
applying patch for #321567

Modified: trunk/bugzilla-2.18.3/debian/bugzilla.postinst
===================================================================
--- trunk/bugzilla-2.18.3/debian/bugzilla.postinst	2005-07-11 06:12:16 UTC (rev 110)
+++ trunk/bugzilla-2.18.3/debian/bugzilla.postinst	2005-09-12 20:31:50 UTC (rev 111)
@@ -86,7 +86,9 @@
 	# The params file will then be updated if needed, the resulting file
 	# will be saved in $params_218_new
 	debug "Running checksetup.pl..."
-	/usr/share/bugzilla/lib/checksetup.pl $answerfile > /tmp/bugzilla.checksetup.log || true
+	tmpfile=`mktemp -t bugzilla.XXXXXX` || { echo "$0: Cannot create temporary file" >&2; exit 1;  }
+	trap " [ -f \"$tmpfile\" ] && /bin/rm -f -- \"$tmpfile\"" 1 2 3 13 15
+	/usr/share/bugzilla/lib/checksetup.pl $answerfile > $tmpfile || true
 	if [ ! -f $params_218_new ]; then
 		echo "Error in postinst: unable to find $params_218_new"
 		exit 13
@@ -99,7 +101,7 @@
 	rm -f $answerfile
 	
 	# a bit of cleaning
-	rm -f /tmp/bugzilla.checksetup.log
+	rm -f $tmpfile
 	
 	# Now, our patched checksetup.pl had made a $params_218.new file, let's 
 	# ask our fellow user if he likes to use it

Modified: trunk/bugzilla-2.18.3/debian/changelog
===================================================================
--- trunk/bugzilla-2.18.3/debian/changelog	2005-07-11 06:12:16 UTC (rev 110)
+++ trunk/bugzilla-2.18.3/debian/changelog	2005-09-12 20:31:50 UTC (rev 111)
@@ -1,3 +1,12 @@
+bugzilla (2.18.3-2) unstable; urgency=low
+
+  * Postinst script now uses temporary files in an safe way, with mktemp
+    rather than using a non-changing path. Thanks to Javier 
+    Fernández-Sanguino Peña.
+    (closes: #321567)
+
+ -- Alexis Sukrieh <sukria at sukria.net>  Mon, 12 Sep 2005 22:28:04 +0200
+
 bugzilla (2.18.3-1) unstable; urgency=low
 
   * New upstream release: 2.18.3