[Pkg-cairo-dock-devel] Bug#643360: cairo-dock: FTBFS: cairo-dock-log.c:78:3: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: cairo-dock
Version: 2.3.0~3-1
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> [ 70%] Building C object src/gldit/CMakeFiles/gldi.dir/cairo-dock-log.c.o
> cd "/build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/obj-x86_64-linux-gnu/src/gldit" && /usr/bin/cc  -Dgldi_EXPORTS -DGL_GLEXT_PROTOTYPES=\"1\" -DCAIRO_DOCK_DEFAULT_ICON_NAME=\"default-icon.svg\" -DCAIRO_DOCK_ICON=\"cairo-dock.svg\" -DCAIRO_DOCK_LOGO=\"cairo-dock-logo.png\" -DCAIRO_DOCK_DATA_DIR=\"cairo-dock\" -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -fPIC -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/librsvg-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/cairo -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/gtkglext-1.0 -I/usr/lib/gtkglext-1.0/include -I"/build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit" -I"/build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/icon-factory" -I"/build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/implementations"    -std=c99 -Wstrict-prototypes -Wextra -Wwrite-strings -Wuninitialized -Werror-implicit-function-declaration -o CMakeFiles/gldi.dir/cairo-dock-log.c.o   -c "/build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c"
> /build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c: In function '_cd_log_level_to_string':
> /build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c:49:3: warning: enumeration value 'G_LOG_FLAG_RECURSION' not handled in switch [-Wswitch]
> /build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c:49:3: warning: enumeration value 'G_LOG_FLAG_FATAL' not handled in switch [-Wswitch]
> /build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c:49:3: warning: enumeration value 'G_LOG_LEVEL_MASK' not handled in switch [-Wswitch]
> /build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c: In function 'cd_log_location':
> /build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c:78:3: error: format not a string literal and no format arguments [-Werror=format-security]
> /build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c: In function 'cairo_dock_log_handler':
> /build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c:85:49: warning: unused parameter 'log_domain' [-Wunused-parameter]
> /build/cairo-dock-6nTsSw/cairo-dock-2.3.0~3/src/gldit/cairo-dock-log.c:88:45: warning: unused parameter 'user_data' [-Wunused-parameter]
> cc1: some warnings being treated as errors
> 
> make[3]: *** [src/gldit/CMakeFiles/gldi.dir/cairo-dock-log.c.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/cairo-dock_2.3.0~3-1_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.