[Pkg-cas-maintainers] dh_auto_install worked with pkg-php-tools woes - Re: [pkg-php-pear] Co-maintainers for phpCAS interested ? - Was: Re: Updating the packaging bits for phpCAS 1.3.1

[Olivier Berger]

Hi.

Thomas Goirand <thomas at goirand.fr> writes:

> On 06/14/2012 01:41 AM, Olivier Berger wrote:
>> Hi.
>> 
>> I've prepared in :
>> http://anonscm.debian.org/gitweb/?p=users/obergix/phpcas.git;h=refs/heads/git-buildpackage%2Bdebpear
>
> Why not using /git/pkg-php instead of your own private Git repo?
>

Cause it was easier for a start. And cause I wanted to go fast instead
of waiting for your advice on where to store it, but that can be changed
easily.

FYI, I also pushed my work to github so as to mark it as a clone of the
upstream repo, in the hope it can be useful wrt git-buildpackage
(security patches tracking and likes).

>> an updated packaging for phpCAS (see also RFP #495542).
>> 
>> phpCAS can be managed as a PEAR package for some time, so I've started
>> over previous packaging attemps, using debpear.
>>
>> I'd appreciate some review, and potential merge requests in order to
>> try and upload it soon in time for wheezy.
>
> * Why did you add some debian/{docs,examples,install} files then? If
> that's a PEAR package, then the package.xml will reference all of these,
> "pear install" called by pkg-php-tools will do the work for you.
>

That's initially what I had started, using the direct result of debpear.

But I didn't like the way dh_auto_install worked with pkg-php-tools :
docs were installed as /usr/share/doc/php-cas/CAS/... instead of
directly under /usr/share/doc/php-cas/, for example for the included
examples/ subdir which should normally be
/usr/share/doc/php-cas/examples/ and not
/usr/share/doc/php-cas/CAS/examples per policy IIRC.

Maybe that's a problem with the package.xml which I could have solved
with a patch, or a problem with pkg-php-tools. But I must say I'm no
expert in debhelper, and I find it more explicit to state what needs to
be installed and where using the debian/[docs|examples|install]
files. The only problem is the path CAS-1.3.1 resulting there, which is
a bit annoying.

Maybe that's another improvement with pkg-php-tools to be able to manage
unversioned directories... but maybe too much demanding WRT the way pear
archives are arriving... 

I've not read all past discussions on pkg-php-pear list so I may be
missing some obvious details.

> * I don't think you need the README.source
>

Yeah, but I'll keep it for a while until my package source repo is a bit
more stable (saving me and comaintainers not using git-buildpackage
daily some more pain).

> * If it's an initial release, please clean-up debian/changelog and have
> only one entry there (eg, that last one from this month). You are
> documenting what's in Debian, not your own work here.
>

Done already (btw, did I report I've uploaded the package to the NEW
queue yesterday late ? ;).

> * I don't believe that the apache-2.0 copyright notice you wrote in
> debian/copyright is enough. Shouldn't you write the full text of it?
>

I'm not sure, but that seems somehow what other packagers have done
already. Lintian didn't complain either.

Maybe the license text doesn't change (no variant for owner of copyright
/ institution names like in other licenses), so that's enough as is.

> * Why did you override_dh_auto_install ?
>

See above.

> * I don't think that the original long description from the package.xml
> is good enough (it's not long enough, Lintian should even complain that
> it should be more than 3 lines long). I believe this should be fixed
> with something more descriptive (replacing ${phppear:description}).
>

Well... I've thought about this but couldn't find a better myself, and
lintian didn't complain so... 

> Also, it'd be great if you could follow the branche naming convention
> that I wrote here:
> http://pkg-php.alioth.debian.org/
>

I'll try and think about it. Thanks. I'll check that when newer versions
need more work. But first, I must work on fusionforge's authcas plugin ;)

> BTW, I have just uploaded a new version of debpear with all of your
> suggestions (thanks for them). See "man debpear" on how to do what you
> needed, I used php-cas as example in the man page! :)
> If it didn't reach your favorite SID repo before you want to try, then
> just build v0.2 from /git/pkg-php/debpear.git on Alioth.
>

I've see you changes. Many thanks.

Thomas Goirand <thomas at goirand.fr> writes:

> On 06/14/2012 01:41 AM, Olivier Berger wrote:
>> Hope you'll find this interesting.
>
> I forgot, of course, I'd be happy if this was maintained in the PKG PEAR
> team, and I may give a hand whenever needed.
>

Thanks.

That's a possibility, but it's not (yet) an "official" PEAR package I
think, even though technically it is... there's also the CAS packaging
team, but which hasn't been very active (it uses SVN, and i'm not sure
how much work it would be in alioth to add/switch to git).

Maybe others will volunteer too, so I'll let a bit of time pass, and
will probably decide on which place it fits best.

In the next uploads I could in any case add the pear team, and maybe the
cas team too as uloaders.

Let's see how it goes, and if more testing, or upstream activity
highlight much need for changes in the package.

> Thomas
>
>

Thanks for all the feedback.

Best regards,
-- 
Olivier BERGER 
http://www-public.it-sudparis.eu/~berger_o/ - OpenPGP-Id: 2048R/5819D7E8
Ingenieur Recherche - Dept INF
Institut Mines-Telecom, Telecom SudParis, Evry (France)