[Pkg-chromium-maint] Comments regarding chromium-browser_5.0.342.9~r43360-1_i386.changes
Alexander Reichle-Schmehl
ftpmaster at debian.org
Wed May 5 12:09:48 UTC 2010
Hi maintainers!
While checking your package, I found some minor glitches in your copyright file:
Files: src/chrome/browser/chromeos/{ipc_message.h}
Copyright: Copyright: 2010 The Chromium OS Authors. All rights reserved:
License: UNKNOWN
File doesn't exist.
Files: src/gpu/command_buffer/common/KHR/{khrplatform.h}
Copyright: Copyright: 2008-2009 The Khronos Group Inc / HOLDERS BE LIABLE FOR ANY:
License: UNKNOWN
Has a license header.
Files: src/net/tools/flip_server/{other_defines.h,string_piece_utils.h}
Copyright: UNKNOWN:
License: *No copyright* UNKNOWN
src/net/tools/flip_server/string_piece_utils.h has a license header.
Files: src/third_party/WebKit/WebCore/manual-tests/NPN_Invoke/{main.c}
Copyright: UNKNOWN:
License: *No copyright* UNKNOWN
Has a license header.
Files: src/third_party/WebKit/WebCore/platform/image-decoders/zlib/{crc32.h,inffixed.h,trees.h}
Copyright: UNKNOWN:
License: *No copyright* UNKNOWN
Folder doesn't exist.
Files: src/third_party/WebKit/WebCore/storage/wince/{DatabaseThreadWince.cpp,DatabaseThreadWince.h,LocalStorageThreadWince.cpp,LocalStorageThreadWince.h}
Copyright: Copyright: 2009 Torch Mobile, Inc. All rights reserved:
License: UNKNOWN
Has a license header.
Files: src/third_party/apple/{ImageAndTextCell.h}
Copyright: Copyright: 2009 Apple Inc. All Rights Reserved:
License: UNKNOWN
Has a license header.
Files: src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/{subsetsequence_unittest.cc}
Copyright: Copyright: 2008 Google Inc. All Rights Reserved:
License: UNKNOWN
Doesn't exist.
Files: src/third_party/cld/bar/toolbar/cld/i18n/encodings/compact_lang_det/generated/{compact_lang_det_generated_ctjkvz_0.cc}
Copyright: Copyright: 2009 Google Inc:
License: UNKNOWN
Doesn't exist.
Files: src/third_party/npapi/npspy/extern/java/{jni_md.h}
Copyright: Copyright: 1998 Netscape Communications Corporation. All / International Business Machines:
License: UNKNOWN
Has a license header (but it seems outdated).
Files: src/v8/src/third_party/dtoa/{dtoa.c}
Copyright: Copyright: 1991, 2000, 2001 by Lucent Technologies:
License: UNKNOWN
Has a license header.
Files: src/webkit/database/{quota_table_unittest.cc}
Copyright: Copyright: 2009 The Chromium Authos. All rights reserved:
License: UNKNOWN
Has a license header.
Files: src/webkit/tools/npapi_layout_test_plugin/{main.cpp,resource.h}
Copyright: UNKNOWN:
License: *No copyright* UNKNOWN
main.cpp has a license header.
Files: src/webkit/tools/pepper_test_plugin/{main.cc}
Copyright: UNKNOWN:
License: *No copyright* UNKNOWN
Has a license header.
The other unknown things in your copyright file are fine with me, as they are
either generated from other files or just so small that I doubt one could have
a copyright on them. So I'm going to accept your package, but please fix the
minor things above. Also it would be nice (if possible) if you could add
information how generated files where generated.
Best regards,
Alexander
More information about the Pkg-chromium-maint
mailing list