[Pkg-chromium-maint] Bug#655521: chromium-browser: Source package does not build on Ubuntu

[Michael Kuhn]

Hi,

> I see.  Maybe the following would be sensible.  Or maybe hard-code
> "Debian" like /usr/bin/chromium does.
> 
> diff --git i/debian/rules w/debian/rules
> index cc4981d2..83cf7a4e 100755
> --- i/debian/rules
> +++ w/debian/rules
> @@ -6,7 +6,11 @@ DEBIAN_UPSTREAM_VERSION	:= $(shell echo $(DEBIAN_VERSION) | sed 's/^\(.*\)-[^-]*
>  DEBIAN_REVISION		:= $(shell echo $(DEBIAN_VERSION) | sed 's/^.*r\([^-]*\)-.*/\1/')
>  DEBIAN_DIST		:= $(shell lsb_release -ds | tr -d '()')
>  DEBIAN_DIST_NAME	:= $(shell lsb_release -si)
> +ifeq (Debian,$(DEBIAN_DIST_NAME))
>  DEBIAN_DIST_VERSION	:= $(shell cat /etc/debian_version)
> +else
> +DEBIAN_DIST_VERSION	:= $(shell lsb_release -sr)
> +endif
>  MULTIARCH		:= $(shell dpkg-architecture -qDEB_BUILD_MULTIARCH)
>  USE_SYSTEM_FFMPEG	:= 1
>  ifeq (1,$(USE_SYSTEM_FFMPEG))

Looks good to me. It may be even better to check for lsb_release and
only fall back to "Debian" and the contents of /etc/debian_version if it
is not available. I modified /usr/bin/chromium to do just that (see
attached patch) -- something similar should be possible for
debian/rules.


Best regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: usr-bin-chromium.patch
Type: text/x-patch
Size: 606 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-chromium-maint/attachments/20120112/2afeaa49/attachment.bin>