[Pkg-chromium-maint] Bug#674728: Bug#674728: #674728 chromium: FTBFS on armel and armhf

[Jérémy Lal]

On 08/07/2012 17:12, shawn wrote:
> On Sun, 2012-07-08 at 12:40 +0200, Jérémy Lal wrote: 
>> On 18/06/2012 00:20, shawn wrote:
>>> CXXFLAGS += -mno-thumb-interwork
>>>
>>> under the armel section
>>
>> If i remember well, I was using a similar 0001 patch for libv8 and
>> using that flag was a better solution. I think it poses problems
>> with armhf builds but i'm not sure.
> This flag is certainly not necessary for armhf, as that warning only
> triggers on <armv7.

It is not necessary indeed. I did not mean it was.


> https://code.google.com/p/v8/issues/detail?id=590
> 
> Which version did you run across it?
> https://code.google.com/p/v8/source/detail?r=5260

Recent enough :)

 
> I just realized that even if it wasn't fixed I wouldn't run across it,
> because I am using armv5t, and blx is a problem for armv4t.
> 
> Maybe there is some way to scan the binaries for use of the offending
> "blx" instruction?
> Otherwise, are any of the porterboxes armv4t that you can run the tests
> with thumb interworking on, to check? I'd rather not turn off features
> that are part of the Debian armel port just because of buggy assembly.

The -mno-thumb-interwork flag is needed to cover precisely the armv4t case,
and is compatible with armv5t. I think you can run into troubles when
using your patch on armv4t, but not on armv5t, hence using the flag without
the patch is a better solution.


Jérémy.