[Pkg-chromium-maint] Bug#841401: chromium: doesn't update extensions

[Daniel Schaal]

Package: chromium
Version: 55.0.2883.75-3
Followup-For: Bug #841401

Attached is a patch that adds a command line switch --disable-extension-update
that disables the update of extensions, which is also added to default-flags.

This way the default is to not update extensions, but this can be overriden by
the user by changing the default-flags file.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (103, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-rc8-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages chromium depends on:
ii  libasound2           1.1.2-1
ii  libatk1.0-0          2.22.0-1
ii  libavcodec57         7:3.2.2-1
ii  libavformat57        7:3.2.2-1
ii  libavutil55          7:3.2.2-1
ii  libc6                2.24-8
ii  libcairo2            1.14.8-1
ii  libcups2             2.2.1-4
ii  libdbus-1-3          1.10.14-1
ii  libevent-2.0-5       2.0.21-stable-2.1
ii  libexpat1            2.2.0-2
ii  libflac8             1.3.2-1
ii  libfontconfig1       2.11.0-6.7
ii  libfreetype6         2.6.3-3+b1
ii  libgcc1              1:6.3.0-2
ii  libgdk-pixbuf2.0-0   2.36.2-1
ii  libglib2.0-0         2.50.2-2
ii  libgtk2.0-0          2.24.31-1
ii  libharfbuzz0b        1.2.7-1+b1
ii  libicu57             57.1-5
ii  libjpeg62-turbo      1:1.5.1-2
ii  libminizip1          1.1-8
ii  libnspr4             2:4.12-6
ii  libnss3              2:3.26.2-1
ii  libpango-1.0-0       1.40.3-3
ii  libpangocairo-1.0-0  1.40.3-3
ii  libpng16-16          1.6.27-1
ii  libpulse0            9.0-5
ii  libre2-3             20170101+dfsg-1
ii  libsnappy1v5         1.1.3-3
ii  libstdc++6           6.3.0-2
ii  libvpx4              1.6.0-3
ii  libwebp6             0.5.2-1
ii  libwebpdemux2        0.5.2-1
ii  libx11-6             2:1.6.4-2
ii  libx11-xcb1          2:1.6.4-2
ii  libxcb1              1.12-1
ii  libxcomposite1       1:0.4.4-1
ii  libxcursor1          1:1.1.14-1+b1
ii  libxdamage1          1:1.1.4-2+b1
ii  libxext6             2:1.3.3-1
ii  libxfixes3           1:5.0.3-1
ii  libxi6               2:1.7.8-2
ii  libxml2              2.9.4+dfsg1-2.1
ii  libxrandr2           2:1.5.1-1
ii  libxrender1          1:0.9.10-1
ii  libxslt1.1           1.1.29-2
ii  libxss1              1:1.2.2-1
ii  libxtst6             2:1.2.3-1
ii  x11-utils            7.7+3
ii  xdg-utils            1.1.1-1
ii  zlib1g               1:1.2.8.dfsg-4

Versions of packages chromium recommends:
ii  fonts-liberation  1:1.07.4-2

Versions of packages chromium suggests:
ii  chromium-l10n  55.0.2883.75-3

-- no debconf information
-------------- next part --------------
>From 83d6812b82b387e2a1395b5b4d9d2935c22cb071 Mon Sep 17 00:00:00 2001
From: Daniel Schaal <daniel at schaal.email>
Date: Thu, 5 Jan 2017 08:26:52 +0100
Subject: [PATCH] Use a switch to disable extension updates to make it
 configurable

---
 debian/default-flags                           |  3 +++
 debian/patches/disable/extension-updater.patch | 11 ++++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/debian/default-flags b/debian/default-flags
index 12d892a7c..95993eb60 100644
--- a/debian/default-flags
+++ b/debian/default-flags
@@ -11,3 +11,6 @@ export CHROMIUM_FLAGS="$CHROMIUM_FLAGS --disable-background-networking"
 
 # Disable the builtin media router (bug #833477)
 export CHROMIUM_FLAGS="$CHROMIUM_FLAGS --media-router=0"
+
+# Disable extension auto updates
+export CHROMIUM_FLAGS="$CHROMIUM_FLAGS --disable-extension-update"
\ No newline at end of file
diff --git a/debian/patches/disable/extension-updater.patch b/debian/patches/disable/extension-updater.patch
index f9e0018c0..72365ae59 100644
--- a/debian/patches/disable/extension-updater.patch
+++ b/debian/patches/disable/extension-updater.patch
@@ -1,14 +1,15 @@
-description: disable automatic extension updating
+description: Add switch to disable auto update of extensions
+author: Daniel Schaal <daniel at schaal.email>
 
 --- a/chrome/browser/extensions/extension_system_impl.cc
 +++ b/chrome/browser/extensions/extension_system_impl.cc
-@@ -186,8 +186,7 @@ void ExtensionSystemImpl::Shared::Init(b
-   // ExtensionService depends on RuntimeData.
+@@ -187,7 +187,8 @@
    runtime_data_.reset(new RuntimeData(ExtensionRegistry::Get(profile_)));
  
--  bool autoupdate_enabled = !profile_->IsGuestSession() &&
+   bool autoupdate_enabled = !profile_->IsGuestSession() &&
 -                            !profile_->IsSystemProfile();
-+  bool autoupdate_enabled = false;
++                            !profile_->IsSystemProfile() &&
++                            !command_line->HasSwitch("disable-extension-update");
  #if defined(OS_CHROMEOS)
    if (!extensions_enabled)
      autoupdate_enabled = false;
-- 
2.11.0