[pkg-cinnamon] nemo-emblems 3.0.0-1
Maximiliano Curia
maxy at debian.org
Fri Jul 22 08:39:44 UTC 2016
¡Hola James!
El 2016-06-06 a las 07:10 -0700, James Lu escribió:
> I've prepared nemo-emblems 3.0.0-1, which is a Nemo extension adding
> emblems for files and folders. The source is currently here:
> https://github.com/GLolol/nemo-emblems-deb, and the ITP is at
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826454.
> Could someone please review it?
Sorry for not reviewing it before. Here is my review.
The watch file doesn't detect the 3.0.1, I suggest:
version=3
http://packages.linuxmint.com/pool/main/n/nemo-emblems/ \
nemo-emblems_([\d.]+)(?:%2b[\w\d]+)?\.tar\.gz
This package depends on the emblem-* icons in the gnome-icon-theme package,
I think that a hard dependency is needed here.
You are missing the Vcs fields in the control file (although we will probably
move it to the pkg-cinnamon umbrella at some point).
The copyright file is missing the copyright information of the translations,
which seems to be under the copyright of:
2014-2016, Rosetta Contributors and Canonical Ltd
Happy hacking,
--
"By definition, when you are investigating the unknown, you do not know what
you will find"
-- The Ultimate Principle
Saludos /\/\ /\ >< `/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cinnamon-team/attachments/20160722/c4da265a/attachment.sig>
More information about the pkg-cinnamon-team
mailing list