[pkg-cinnamon] nemo-emblems 3.0.1-1 (WAS: Re: nemo-emblems 3.0.0-1)

[James Lu]

Hi everyone,

I've uploaded a newer version of nemo-emblems 3.0.1-1 to Mentors:
https://mentors.debian.net/package/nemo-emblems. The Git source remains
at https://github.com/GLolol/nemo-emblems-deb for now, and the ITP at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826454.

I've addressed Maximiliano's concerns from the last review. Is the
package now fit for upload? :)

Best,
James

On 22/07/2016 11:44 AM, James Lu wrote:
> Hi Maximiliano,
> 
> I've applied your suggestions. :) For now the the Vcs- fields point to
> GitHub, but I'd be happy to move it into Alioth too.
> 
> Thanks for reviewing!
> 
> James
> 
> On 22/07/2016 1:39 AM, Maximiliano Curia wrote:
>> ¡Hola James!
>>
>> El 2016-06-06 a las 07:10 -0700, James Lu escribió:
>>> I've prepared nemo-emblems 3.0.0-1, which is a Nemo extension adding
>>> emblems for files and folders. The source is currently here:
>>> https://github.com/GLolol/nemo-emblems-deb, and the ITP is at
>>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826454.
>>
>>> Could someone please review it?
>>
>> Sorry for not reviewing it before. Here is my review.
>>
>> The watch file doesn't detect the 3.0.1, I suggest:
>> version=3
>> http://packages.linuxmint.com/pool/main/n/nemo-emblems/ \
>>     nemo-emblems_([\d.]+)(?:%2b[\w\d]+)?\.tar\.gz
>>
>> This package depends on the emblem-* icons in the gnome-icon-theme
>> package, I think that a hard dependency is needed here.
>>
>> You are missing the Vcs fields in the control file (although we will
>> probably move it to the pkg-cinnamon umbrella at some point).
>>
>> The copyright file is missing the copyright information of the
>> translations, which seems to be under the copyright of:
>> 2014-2016, Rosetta Contributors and Canonical Ltd
>>
>> Happy hacking,
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cinnamon-team/attachments/20160813/2185e5bb/attachment.sig>