[Pkg-cli-apps-commits] [SCM] banshee-community-extensions branch, ubuntu, updated. debian/1.6.0-1ubuntu4-1-gbda4c9f

[Chow Loong Jin]

The following commit has been merged in the ubuntu branch:
commit bda4c9f4e42c4b1056c8db59be7a29763b73c6e8
Author: Chow Loong Jin <hyperair at ubuntu.com>
Date:   Fri Apr 23 22:36:38 2010 +0800

    Add 0001-AppIndicator-Stopping-the-notifications-from-lagging.patch to fix notification lag with Notify OSD (LP: #566112)

diff --git a/debian/changelog b/debian/changelog
index 9bdd5d0..152c83c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+banshee-community-extensions (1.6.0-1ubuntu5) lucid; urgency=low
+
+  * Add 0001-AppIndicator-Stopping-the-notifications-from-lagging.patch to
+    fix notification lag with Notify OSD (LP: #566112)
+
+ -- Chow Loong Jin <hyperair at ubuntu.com>  Fri, 23 Apr 2010 22:36:16 +0800
+
 banshee-community-extensions (1.6.0-1ubuntu4) lucid; urgency=low
 
   * debian/control:
diff --git a/debian/patches/0001-AppIndicator-Stopping-the-notifications-from-lagging.patch b/debian/patches/0001-AppIndicator-Stopping-the-notifications-from-lagging.patch
new file mode 100644
index 0000000..60b3d45
--- /dev/null
+++ b/debian/patches/0001-AppIndicator-Stopping-the-notifications-from-lagging.patch
@@ -0,0 +1,44 @@
+From 685af29c9be5391cfee1c317d10ee3eeb434404e Mon Sep 17 00:00:00 2001
+From: Sense Hofstede <qense at ubuntu.com>
+Date: Fri, 23 Apr 2010 16:05:27 +0200
+Subject: [PATCH] [AppIndicator] Stopping the notifications from lagging in Banshee.AppIndicator
+
+Notify OSD doesn't do much on the NotificationClose signal, which means that if
+you .Close() the notification it will still stay around until it expires anyway.
+This meant that when the CurrentTrack was changed while the notification was still
+being show, the notifications would stack.
+Closes: bgo#616652
+---
+ .../Banshee.AppIndicator/AppIndicatorService.cs    |   11 -----------
+ 1 files changed, 0 insertions(+), 11 deletions(-)
+
+diff --git a/src/AppIndicator/Banshee.AppIndicator/AppIndicatorService.cs b/src/AppIndicator/Banshee.AppIndicator/AppIndicatorService.cs
+index 4bba19c..8d0159f 100644
+--- a/src/AppIndicator/Banshee.AppIndicator/AppIndicatorService.cs
++++ b/src/AppIndicator/Banshee.AppIndicator/AppIndicatorService.cs
+@@ -235,22 +235,11 @@ namespace Banshee.AppIndicator
+         {
+             switch (args.Event) {
+                 case PlayerEvent.StartOfStream:
+-                    if (current_nf != null) {
+-                        current_nf.Close ();
+-                        current_nf = null;
+-                    }
+-                    current_track = ServiceManager.PlayerEngine.CurrentTrack;
+-                    ShowTrackNotification ();
+-                    break;
+                 case PlayerEvent.TrackInfoUpdated:
+                     current_track = ServiceManager.PlayerEngine.CurrentTrack;
+                     ShowTrackNotification ();
+                     break;
+                 case PlayerEvent.EndOfStream:
+-                    if (current_nf != null) {
+-                        current_nf.Close ();
+-                        current_nf = null;
+-                    }
+                     current_track = null;
+                     break;
+             }
+-- 
+1.6.3.3
+
diff --git a/debian/patches/series b/debian/patches/series
index 1af8286..297789f 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
+0001-AppIndicator-Stopping-the-notifications-from-lagging.patch
 0001-Use-banshee-panel-icon.patch
 99_ignore-quilt.patch

-- 
banshee-community-extensions